-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename all instances of mm2 to kdf #2462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing was successful here. Couldn't find any issues during smoke tests.
The following processes were tested:
- Installation where previous data exists on environment
- Log in to existing wallet on environment
- Complete swap on existing wallet
- Clean installation
- Import wallet
- Create wallet
- Complete swap on imported wallet
- Complete swap on new wallet
- Recieve to imported wallet
- Send from imported wallet
Problem is that directory with DB was renamed to kdf from mm2, so when you update you will loose the entire swap history (then failed swaps can't be refunded any more) and also the ARRR-DBs. Directory should be moved back to mm2 or we need a way to upgrade, like moving the directory including it's entire content. |
Completed the Smoke Testing here, and everything looks fine.
|
Latest commit should resolve this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works fine now, mm2 dir is renamed to kdf and swap history retained
Closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2463
Basic smoke test needed:
Repeat the above with an existing wallet (created before this build)