Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all instances of mm2 to kdf #2462

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Rename all instances of mm2 to kdf #2462

merged 5 commits into from
Aug 21, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jul 30, 2024

Closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2463

Basic smoke test needed:

  • create/import wallet
  • login
  • send a transaction
  • do a swap

Repeat the above with an existing wallet (created before this build)

@smk762 smk762 changed the title use dev api Rename all instances of mm2 to kdf Aug 9, 2024
@smk762 smk762 added the v0.8.0 label Aug 12, 2024
AndrewDelaney
AndrewDelaney previously approved these changes Aug 16, 2024
Copy link
Collaborator

@AndrewDelaney AndrewDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing was successful here. Couldn't find any issues during smoke tests.
The following processes were tested:

  • Installation where previous data exists on environment
  • Log in to existing wallet on environment
  • Complete swap on existing wallet
  • Clean installation
  • Import wallet
  • Create wallet
  • Complete swap on imported wallet
  • Complete swap on new wallet
  • Recieve to imported wallet
  • Send from imported wallet

@cipig
Copy link
Member

cipig commented Aug 16, 2024

Problem is that directory with DB was renamed to kdf from mm2, so when you update you will loose the entire swap history (then failed swaps can't be refunded any more) and also the ARRR-DBs. Directory should be moved back to mm2 or we need a way to upgrade, like moving the directory including it's entire content.

@ShantanuSharma9873
Copy link
Collaborator

Completed the Smoke Testing here, and everything looks fine.

  • Logged in to an existing Wallet
  • Completed a SWAP
  • Imported a Wallet
  • Logged in successfully
  • Completed a SWAP
  • Created a New Wallet
  • Logged in successfully
  • Completed a SWAP

@smk762
Copy link
Collaborator Author

smk762 commented Aug 19, 2024

Problem is that directory with DB was renamed to kdf from mm2, so when you update you will loose the entire swap history (then failed swaps can't be refunded any more) and also the ARRR-DBs. Directory should be moved back to mm2 or we need a way to upgrade, like moving the directory including it's entire content.

Latest commit should resolve this.

Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine now, mm2 dir is renamed to kdf and swap history retained

@smk762 smk762 merged commit 893c032 into dev Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pending update: mm2 -> kdf in coins file
4 participants