Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#77 Upgrade GraphQL example to Knot.x 2.2.1 #79

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

tomaszmichalak
Copy link
Member

Description

Relates to #77.

Motivation and Context

Upgrade the GraphQL to the latest Knot.x version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

GraphQLHandlerFactory factory = new GraphQLHandlerFactory();
getConfig(conf -> {
// given
String query = "{\"query\": \"{"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider loading these from file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked in in Intellij, there is no support for graphql query syntax.

@tomaszmichalak tomaszmichalak merged commit 69a98fa into master Jul 30, 2020
@tomaszmichalak tomaszmichalak deleted the feature/upgrade-graphql-example branch July 30, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants