Knotx/knotx-example-project#58 refactor OAuth2 security #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2020 16:38
…urity-example-oauth2 # Conflicts: # api-gateway/security/knotx/conf/openapi.yaml # api-gateway/security/knotx/conf/routes/operations.conf
marcinus
approved these changes
Jan 29, 2020
marcinus
reviewed
Jan 29, 2020
|
|
||
| public class OAuth2HelloHandlerFactory implements AuthHandlerFactory { | ||
|
|
||
| private OAuth2AuthHandler oAuth2AuthHandler; |
There was a problem hiding this comment.
What if configuration contains two entries for this OAuthHelloHandlerFactory?
There was a problem hiding this comment.
in io.knotx.server.SecurityProvider reference to factories is a map<factoryName, factory reference>, so it will be unique anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor OAuth2 tutorial to use OOTB Vert.x implementation of OAuth2 flow
Description
The routing logic has been moved to correct security logic and now uses OOTB Vert.x stuff.
Motivation and Context
In previous approach, the OAuth2 flow was mixed with business logic.
Screenshots (if appropriate)
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.