Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extrude can send IDs for the new faces #619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adamchalmers
Copy link
Collaborator

When extruding a 2D shape into a 3D shape, a bunch of new faces are created. These faces need IDs. The backend currently generates these IDs randomly. Add a new option to allow the client to send the IDs.

When extruding a 2D shape into a 3D shape, a bunch of new faces are created.
These faces need IDs. The backend currently generates these IDs randomly.
Add a new option to allow the client to send the IDs.
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@7353881). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #619   +/-   ##
=======================================
  Coverage        ?   24.00%           
=======================================
  Files           ?       35           
  Lines           ?     2029           
  Branches        ?        0           
=======================================
  Hits            ?      487           
  Misses          ?     1542           
  Partials        ?        0           
Flag Coverage Δ
unittests 24.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant