Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

AP22913CN4-7 load switch #2864

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP22913CN4-7 load switch #2864

wants to merge 1 commit into from

Conversation

chmorgan
Copy link
Collaborator

@chmorgan chmorgan commented Jul 18, 2020

OnSemi load control switch

Footprint pull request: KiCad/kicad-footprints#2364

image

https://www.diodes.com/assets/Datasheets/AP22913.pdf


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jul 21, 2020
@myfreescalewebpage myfreescalewebpage self-assigned this Jul 28, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Jul 28, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Jul 28, 2020

Hi @chmorgan , thanks for contributing,

A few comments I have during my review:

  • The name of the symbol should be AP22913CN4
  • The description should be Slew rate controlled load switch, WLCSP-4
  • You should submit the footprint in footprint library
  • The footprint filter should be WLCSP*X1*WLB0909*0.890x0.890*P0.500mm*
  • Name of pin A1 is VOUT
  • Name of pin A2 is VIN

The SOT-26 symbol is not the same, should be a different symbol. You can submit it in this PR or in another PR if you want.

Cheers,
Joel

@chmorgan
Copy link
Collaborator Author

HI @myfreescalewebpage.

I don't see any mention in the KLC about the regulator or control conventions around pin naming. I copied the convention used by the other power switches.

For power management should the pins match the datasheet pin names?

For regulators I take it they should always be IN and OUT even if it doesn't match the datasheet pin names?

Chris

@myfreescalewebpage
Copy link
Collaborator

@chmorgan thanks for the fixes,

We try for all devices to have pin matching the datasheet. This is really better because this can trouble people later when using the symbol.

Some exception (still valid) have been made for some very common regulators in which the datasheet pins names are "INPUT" and "OUTPUT". This is too much long and in this case we have preferred "IN" and "OUT" but this remains an exception.

Joel

@myfreescalewebpage myfreescalewebpage added the Pending footprint Pending footprint acceptance before merging label Aug 2, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending footprint Pending footprint acceptance before merging label Sep 30, 2020
@myfreescalewebpage
Copy link
Collaborator

Closing/opening to refresh the Travis test.

@myfreescalewebpage
Copy link
Collaborator

@chmorgan two comments here:

  • Fp and fp filter to be updated according to the new fp name
  • Pin B2 name should be "ON"

Joel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants