Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add the TI TS3A27518E 6-channel 1:2 analog mux #2092

Merged
merged 9 commits into from
Sep 15, 2019
Merged

Add the TI TS3A27518E 6-channel 1:2 analog mux #2092

merged 9 commits into from
Sep 15, 2019

Conversation

jonas-schievink
Copy link
Contributor

@jonas-schievink jonas-schievink commented Aug 18, 2019

This adds the WQFN and TSSOP packages. There's also a BGA variant using "24-pin BGA Microstar Junior", which not in the footprint library. I might add that in a later PR, but for now these 2 variants should be fine.

Footprint PR: KiCad/kicad-footprints#1785

screenshot-2019-08-19-13:59:48


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue
Copy link
Contributor

chschlue commented Aug 18, 2019

  • Add packages to the descriptions
  • WQFN EP is too large
  • BGA is EOL, can probably be left out
  • : is disallowed

@jonas-schievink
Copy link
Contributor Author

WQFN EP is too large

True, 2.6mm instead of 2.45mm. Do you usually create an entirely new footprint in this case?

: is disallowed

Do you mean in the symbol description? (the guidelines don't mention this, they only say what's disallowed in symbol names)

@chschlue
Copy link
Contributor

True, 2.6mm instead of 2.45mm. Do you usually create an entirely new footprint in this case?

Easier than it sounds, QFN footprints are scripted.
You basically add it to https://github.com/pointhi/kicad-footprint-generator/blob/master/scripts/Packages/Package_NoLead__DFN_QFN_LGA_SON/size_definitions/qfn/wqfn.yaml , generate it, create an FP PR and cross-reference them (generator, FP and symbol PRs)

Do you mean in the symbol description? (the guidelines don't mention this, they only say what's disallowed in symbol names)

That should probably be clarified.

@chschlue
Copy link
Contributor

@jonas-schievink
Copy link
Contributor Author

jonas-schievink commented Aug 18, 2019

I think I didn't do the N.C. pin right. What electrical type should it get? Is "Not Connected" right?

Oh, also:

Pin GND (25) : POWER INPUT should be visible (power-in/power-out pins may never be invisible, unless in a power-net tag/symbol)

Should the EP not be set as "Power Input"? Ah, it should be set to "Passive" according to http://kicad-pcb.org/libraries/klc/S4.3/

@chschlue
Copy link
Contributor

You could set it to invisible, type NC and place its end on the symbol outline.
That way it's out of the way but still able to be connected if one really wants to.

@poeschlr
Copy link
Collaborator

NC pins must be set to invisible and placed inside the symbol outline (or on the outline itself depending on if the outline is on the grid for pins)

See: KiCad/kicad-website#377 for a clarified version of the NC pin rule set.

@chschlue
Copy link
Contributor

Apart from the fact that invisible and placed inside the symbol outline is the current state of this PR, you can't expect anyone to follow future KLC versions.

@poeschlr
Copy link
Collaborator

poeschlr commented Aug 19, 2019

I only clarified that "should" simply is not strong enough. The KLC rules were sadly written in polite voice. In reality however this is a "must" rule. (which is what i intended to both clarify in the rule update and in my comment.)

Edit: regarding the "inside the symbol part": pins must still be on the outline if said outline is on the grid. (My wording in my comment here was indeed ambiguous, the rule update however makes this clear.)

@jonas-schievink
Copy link
Contributor Author

See: KiCad/kicad-website#377 for a clarified version of the NC pin rule set.

Thanks, that's helpful.

I've fixed the remaining warnings in the CI script and also updated the screenshot to reduce confusion.

@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Aug 24, 2019
@chschlue chschlue self-assigned this Sep 7, 2019
@chschlue chschlue removed the Pending reviewer A pull request waiting for a reviewer label Sep 7, 2019
@chschlue
Copy link
Contributor

chschlue commented Sep 7, 2019

Keywords must be separated by spaces. Everything else looks nice.
Edit: TI as a keyword is unnecessary.

@chschlue chschlue merged commit 2ec6c5c into KiCad:master Sep 15, 2019
@jonas-schievink jonas-schievink deleted the ts3a27518e branch September 15, 2019 13:35
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.5 milestone Sep 16, 2019
pull bot pushed a commit to maximeborges/kicad-symbols that referenced this pull request Oct 5, 2019
* Add the TI TS3A27518E 6-channel 1:2 analog mux

* Shrink the symbols a bit

* Add packages to the symbol description

* Remove `:` from description

* Expose the N.C. pins and stack EP with GND

* Make the N.C. pin invisible

* Fix footprint filters

* Shorten pins and fix the pin name offset

* Fix symbol keywords
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants