This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Add initial support for custom pad shapes #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds initial support for custom pad shapes in the KicadMod class. The class can now load all custom pad primitives. It can also check the bounding box of all custom pad primitives except for arcs, which will be more complicated to implement than the others. Since there are no footprints in kicad-footprints yet that use arc primitives in custom pads, I don't think this is a problem yet. 🙂 There is no support for exporting custom pad information yet.
4 tasks
|
I can not see anything obviously wrong. |
|
Yes, I tested it locally. It correctly processes KiCad/kicad-footprints#461, and a test footprint I kept adding random primitives to while writing this. |
|
@poeschlr |
|
Oh yes. sorry forgot about that. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for custom pad shapes in the KicadMod class. This does most of the work described in #231. The KicadMod class can now load all custom pad primitives. It can also check the bounding box of all custom pad primitives except for arcs, which will be more complicated to implement than the others. Since there are no footprints in kicad-footprints yet that use arc primitives (or in fact, any primitives except for polygons) in custom pads, I don't think this is a problem yet. 🙂
There is no support for exporting custom pad information yet either.