Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Change nxe2 sxxxx mc tht name #2065

Closed
wants to merge 3,623 commits into from
Closed

Change nxe2 sxxxx mc tht name #2065

wants to merge 3,623 commits into from

Conversation

od83
Copy link
Contributor

@od83 od83 commented Jan 18, 2020

Hi,

What I did:

  1. remove Converter_DCDC.pretty/Converter_DCDC_muRata_NXE2SxxxxMC_THT.kicad_mod
  2. add Converter_DCDC.pretty/Converter_DCDC_muRata_NXExSxxxxMC_SMD.kicad_mod

I did not change the footprint itself, only (file)name and description.

Why I did it:
a. The footprint is (and was) a SMD type, not THT type.
b. The footprint can also be used for the NXE1S Series of Murata's 1W DC/DC converters

Reference:
NXE1 Series
NXE2 Series

Symbol pull request for added NXE1S0x0xMC and changed NXE2SxxxxMC are here.

PAD_NXExSxxxxMC_SMD

Best regards,
Oliver


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing a dimensioned drawing of your contribution. A tutorial on how to do that is found here: https://forum.kicad.info/t/how-to-check-footprint-correctness/9279 (This is optional!)

chschlue and others added 30 commits September 10, 2019 22:31
Fix DirectFET SH Fab and Courtyard
Fix DirectFET ST Fab and Courtyard
Fix DirectFET SQ Fab and Courtyard
Fix DirectFET SJ Fab and Courtyard
* Buzzer AT-0927-TT-6-R added
Fix DirectFET L8 silk and courtyard
persus and others added 18 commits January 5, 2020 22:51
Add missing non thermal vias footprint for LMZM23601
Fix EP radius and resync of LGA footprints
Add missing scripted variants of SO packages
Package_SO fix EP round radius
Fix EP round radius for TI QFN footpirnts
Fix EP round radius for xQFN footprints
Fix EP round radius for QFN footprints
Remove wrongly added qfn (manufactuer specific one is in RF lib)
@claassistantio
Copy link

claassistantio commented Jan 18, 2020

CLA assistant check
All committers have signed the CLA.

@poeschlr poeschlr added Bug Fix footprint existing in the library Pending reviewer A pull request waiting for a reviewer labels Jan 19, 2020
@od83
Copy link
Contributor Author

od83 commented Jan 22, 2020

Is the license/cla pending a blocking issue?
I can't get it resolved by rechecking.
I signed the CLA but it is not recognized since I didn't have an email address set in git by that time

Please let me know if I need to start a new Branch / PR

@chschlue
Copy link
Contributor

Yes, that's a blocking issue. But adding the address to GH afterwards and closing and reopening this PR should do the trick.

@od83
Copy link
Contributor Author

od83 commented Jan 23, 2020

merge 3,623 commits? No!

I tried to change the git history in order to fix my "author" in the envelope.
However, this is not what I intended. I'll close this PR, delete the branch and start over.

Sorry for the inconveniences.

@od83 od83 closed this Jan 23, 2020
@od83 od83 deleted the change_NXE2SxxxxMC_THT_name branch January 23, 2020 10:42
@od83
Copy link
Contributor Author

od83 commented Jan 23, 2020

merge 3,622 commits? No.
I tried to rewrite (GIT) history. Never a good idea.
I'll close this PR and start over fresh.

Sorry about the inconveniences.

The new PR

@myfreescalewebpage myfreescalewebpage added Abandoned Original author has stopped working on the PR and removed Pending reviewer A pull request waiting for a reviewer labels Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Abandoned Original author has stopped working on the PR Bug Fix footprint existing in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.