Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Add Finder 36.11 10A SPDT relay footprint #1728

Merged
merged 4 commits into from
Jul 29, 2019
Merged

Conversation

chschlue
Copy link
Contributor

@chschlue chschlue commented Jul 22, 2019

Add Finder 36.11 10A SPDT relay footprint

Datasheet: https://gfinder.findernet.com/public/attachments/36/EN/S36EN.pdf
Symbol: KiCad/kicad-symbols#1998

Violating F7.[23]: Component has no pin 1

3611foot


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@chschlue chschlue marked this pull request as ready for review July 22, 2019 07:12
@antoniovazquezblanco antoniovazquezblanco added Addition Adds new footprint to library Pending reviewer A pull request waiting for a reviewer labels Jul 22, 2019
@antoniovazquezblanco
Copy link
Collaborator

Depends on KiCad/kicad-website#418

@evanshultz evanshultz self-assigned this Jul 29, 2019
@evanshultz
Copy link
Collaborator

  1. Please add a documentation link to the description.
  2. I think you can remove the "1" text.
  3. Could you please rotate the pads to 0 degrees?
  4. Please bump in the courtyard so it's 0.25mm offset from pads/body. Now it's 0.3mm:
    image

@chschlue
Copy link
Contributor Author

Done

@evanshultz
Copy link
Collaborator

Thanks! Looks great!

@evanshultz evanshultz merged commit c2578a1 into KiCad:master Jul 29, 2019
@myfreescalewebpage myfreescalewebpage removed Pending KLC issue This depends on a open KLC issue Pending reviewer A pull request waiting for a reviewer labels Jul 31, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.4 milestone Aug 21, 2019
@antoniovazquezblanco
Copy link
Collaborator

AFAIK this does not conform to the newest naming convention KiCad/kicad-website#418

This will probably require an update

@chschlue
Copy link
Contributor Author

Sure, as soon as the powers that be can make up their minds regarding KiCad/kicad-website#418

@poeschlr
Copy link
Collaborator

poeschlr commented Aug 22, 2019

No matter what we decide it will only really come into effect with version 6. The reason we will hold new contributions to the new standard before that is to reduce the required work for getting everything done for v6.

Edit: and to get experience with it to see if it works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants