Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added BatteryHolder_Keystone_3002 #1622

Merged
merged 1 commit into from
Jun 2, 2019

Conversation

valerionew
Copy link
Contributor

@valerionew valerionew commented Jun 2, 2019

New pull request based on the current master, to avoid problems with travis CI.

Deprecates #1183, which will be kept open for testing and analyisis purposes upon mantainers' request.
See:
#1183 (comment)
#1384
KiCad/kicad-library-utils#302

A larger pad than the minimum in the datasheet is used for the negative pad, to improve the direct pcb-battery contact.

image


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@poeschlr poeschlr self-assigned this Jun 2, 2019
@poeschlr poeschlr added the Addition Adds new footprint to library label Jun 2, 2019
@poeschlr
Copy link
Collaborator

poeschlr commented Jun 2, 2019

Thanks, looks good

@poeschlr poeschlr merged commit 6be75c9 into KiCad:master Jun 2, 2019
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.3 milestone Jun 3, 2019
@valerionew valerionew deleted the BatteryHolder_updated_upstream branch June 4, 2019 07:02
@valerionew valerionew restored the BatteryHolder_updated_upstream branch June 4, 2019 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new footprint to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants