Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CI. Update README. #33

Closed
wants to merge 2 commits into from
Closed

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Oct 15, 2023

Fixes #27

@DRx3D
Copy link
Contributor

DRx3D commented Oct 24, 2023

@javagl : Please check this. I renamed the YML file (php.yml --> AssetCheck.yml) and changed it to only do check and report. The README change appears to still apply.

@javagl
Copy link
Contributor Author

javagl commented Oct 24, 2023

@DRx3D I'll try to update this PR to include the new check with the AssetCheck.yml, and maybe try to create an action that runs when PRs are merged, to update the index files. This would mean that the change in the README could be omitted, and it would automate what is currently done with b21d727 ). The latter should not cause any permission issues 🤞 because it's all running in (and only affecting) this repository.

@javagl
Copy link
Contributor Author

javagl commented Oct 25, 2023

Since this PR only deletes the existing file (which should not be done for the final solution), and modifies the README (which should not be necessary in the final solution), I'd rather close this, and try to set up an action that updates the index file when PRs are merged, maybe based on https://stackoverflow.com/questions/60710209/trigger-github-actions-only-when-pr-is-merged ...

@javagl javagl closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builds are failing
2 participants