Add constraint to vec <<, >> operators #664
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume it was simply an oversight that we forgot to add this constraint to these operators. This synopsis already listed the constraint in its comment, so this change just brings the description into alignment with the synopsis. C++ does not allow `<<` or `>>` operators where the left-hand-side is a floating point value. In addition, DPC++ already diagnoses an error if you attempt to use `vec::operator<<` where the left-hand-side is a floating point value.
TApplencourt
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume it was simply an oversight that we forgot to add this constraint to these operators. This synopsis already listed the constraint in its comment, so this change just brings the description into alignment with the synopsis.
C++ does not allow
<<or>>operators where the left-hand-side is a floating point value. In addition, DPC++ already diagnoses an error if you attempt to usevec::operator<<where the left-hand-side is a floating point value.