-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename hipSYCL to AdaptiveCpp, update CI and regenerate filter #874
base: main
Are you sure you want to change the base?
Conversation
…sycl-to-adaptivecpp
Newer versions of AdaptiveCpp (hipSYCL) require GCC >= 10.
I'm not sure it's a good idea. These PRs have some unresolved comments and pre-commit failures, which will take time to resolve. Requesting them to be merge first blocks other useful work, which is not directly related to adding SimSYCL support. I think we can merge fix for #796 and remove the Intel_SYCL separately. |
Are we in a hurry to get this merged? IMO waiting another week or two to get those issues resolved doesn't really make a difference at this point. My main goal for today's call was to assess AdaptiveCpp's current CTS coverage, and not including @fknorr's fixes will negatively affect that. |
How do we move on this? |
@fknorr Some merge conflicts. |
NOTE: This includes @fknorr's recent PRs (#870, #871, #872, #873), so those should be merged first.
This renames (hopefully) all uses of hipSYCL to AdaptiveCpp and updates the version checked against in CI to the latest develop commit (the previous version was over 2 years old at this point).
I've also gone ahead and re-generated the CI exclude filters: AdaptiveCpp is now able to compile 7 additional categories (device, exception_handling, image, marray, nd_range, range and vector_alias), while failing 2 new categories (group_functions and optional_kernel_features, although I believe those didn't even exist yet the last the filter was generated).
I had to bump our CI docker container base image to Ubuntu 22.04, as the GCC included in 20.04 is too old for current AdaptiveCpp.
I've also taken the liberty of removing the long deprecated
Intel_SYCL
option forSYCL_IMPLEMENTATION
.cc @illuhad
Closes #796.