Include lint and test jobs for node-ci-push workflow (using reusable workflow) #2348

beaesguerra · 2024-10-17T20:50:17Z

Summary:

Lint and test jobs from node-ci-pr.yml are also run in the node-ci-push.yml workflow
- this is done so that feature branches can be updated with the latest changes in main (there are currently branch protection rules on feature/* branches that require these status checks to pass)
Lint and test jobs are refactored into reusable workflows so that both node-ci-push and node-ci-pr can use the same config

See #2346 for an alternative where we use composite actions instead to share configuration

Update: We decided to use reusable workflows so that the logs are easier to read for the steps and we can use the secrets config (which isn't supported by composite actions). The branch rules have been updated to look for Lint / Lint and Test / Test checks.

Pros:

shared configuration for node-ci-push and node-ci-pr
easy to see the logs for the different steps:

Cons:

since we are using another workflow, the names of the jobs are nested (ie. Node CI (PR) / Lint / Lint instead of just Node CI (PR) / Lint ) and the github checks will need to be updated (let me know though if there's a way around this!)

Issue: WB-1778

Test plan:

Confirm linting and tests run in CI
Confirm steps properly fail when there are linting errors, typescript errors, and failing tests

…bled on feature branches (this is so feature branches can be updated with main)

changeset-bot · 2024-10-17T20:50:21Z

⚠️ No Changeset found

Latest commit: 89c9872

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This reverts commit 85b247d.

beaesguerra · 2024-10-17T21:06:32Z

.github/workflows/node-ci-push.yml


-  coverage:


This job can be removed since the Test workflow also gathers coverage!

github-actions · 2024-10-17T21:07:51Z

Size Change: 0 B

Total Size: 100 kB

ℹ️ View Unchanged

Filename	Size
`packages/wonder-blocks-accordion/dist/es/index.js`	3.78 kB
`packages/wonder-blocks-banner/dist/es/index.js`	1.53 kB
`packages/wonder-blocks-birthday-picker/dist/es/index.js`	1.77 kB
`packages/wonder-blocks-breadcrumbs/dist/es/index.js`	887 B
`packages/wonder-blocks-button/dist/es/index.js`	4.04 kB
`packages/wonder-blocks-cell/dist/es/index.js`	2.01 kB
`packages/wonder-blocks-clickable/dist/es/index.js`	3.06 kB
`packages/wonder-blocks-core/dist/es/index.js`	3.44 kB
`packages/wonder-blocks-data/dist/es/index.js`	6.24 kB
`packages/wonder-blocks-dropdown/dist/es/index.js`	18.2 kB
`packages/wonder-blocks-form/dist/es/index.js`	6.21 kB
`packages/wonder-blocks-grid/dist/es/index.js`	1.36 kB
`packages/wonder-blocks-i18n/dist/es/index.js`	4.76 kB
`packages/wonder-blocks-icon-button/dist/es/index.js`	3 kB
`packages/wonder-blocks-icon/dist/es/index.js`	828 B
`packages/wonder-blocks-labeled-field/dist/es/index.js`	72 B
`packages/wonder-blocks-layout/dist/es/index.js`	1.82 kB
`packages/wonder-blocks-link/dist/es/index.js`	2.28 kB
`packages/wonder-blocks-modal/dist/es/index.js`	5.36 kB
`packages/wonder-blocks-pill/dist/es/index.js`	1.65 kB
`packages/wonder-blocks-popover/dist/es/index.js`	4.87 kB
`packages/wonder-blocks-progress-spinner/dist/es/index.js`	1.52 kB
`packages/wonder-blocks-search-field/dist/es/index.js`	1.3 kB
`packages/wonder-blocks-switch/dist/es/index.js`	1.94 kB
`packages/wonder-blocks-testing-core/dist/es/index.js`	3.74 kB
`packages/wonder-blocks-testing/dist/es/index.js`	1.07 kB
`packages/wonder-blocks-theming/dist/es/index.js`	693 B
`packages/wonder-blocks-timing/dist/es/index.js`	1.8 kB
`packages/wonder-blocks-tokens/dist/es/index.js`	2.1 kB
`packages/wonder-blocks-toolbar/dist/es/index.js`	827 B
`packages/wonder-blocks-tooltip/dist/es/index.js`	7.08 kB
`packages/wonder-blocks-typography/dist/es/index.js`	1.23 kB

_{compressed-size-action}

github-actions · 2024-10-17T21:09:21Z

A new build was pushed to Chromatic! 🚀

https://5e1bf4b385e3fb0020b7073c-lthespwsvf.chromatic.com/

Chromatic results:

Metric	Total
Captured snapshots	7
Tests with visual changes	0
Total stories	497
Inherited (not captured) snapshots [TurboSnap]	365
Tests on the build	372

beaesguerra · 2024-10-17T21:38:07Z

.github/workflows/node-ci-pr.yml

-          token: ${{ secrets.CODECOV_TOKEN }}
-          files: ./coverage/coverage-final.json
+    uses: ./.github/workflows/node-ci-test.yml
+    secrets:


Here, we are able to pass tokens using secrets

khan-actions-bot · 2024-10-17T21:55:42Z

Gerald

Required Reviewers

@Khan/wonder-blocks for changes to .github/workflows/node-ci-lint.yml, .github/workflows/node-ci-pr.yml, .github/workflows/node-ci-push.yml, .github/workflows/node-ci-test.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

github-actions · 2024-10-17T21:56:10Z

npm Snapshot: NOT Published

🤕 Oh noes!! We couldn't find any changesets in this PR (edb0ac0). As a result, we did not publish an npm snapshot for you.

jandrade

This is a great improvement! thanks for the detailed description and iterating on the problem 👏 🚀

beaesguerra · 2024-10-18T21:58:32Z

Added some notes around these findings here: https://khanacademy.atlassian.net/wiki/x/AYGUyQ

beaesguerra added 6 commits October 15, 2024 14:46

copy lint and test jobs from node-ci-pr.yml so that checks can be ena…

eb0ecc4

…bled on feature branches (this is so feature branches can be updated with main)

set up separate lint workflow and test with pr workflow

c4dea85

temporarily disable other pr checks for testing

85b247d

add printing message to see if new workflow was used

8695578

fix error

979c839

update name in reusable workflow

6e587b1

beaesguerra self-assigned this Oct 17, 2024

beaesguerra added 5 commits October 17, 2024 14:55

add reusable workflow for tests

f8ac5aa

Revert "temporarily disable other pr checks for testing"

fab8c6d

This reverts commit 85b247d.

cleanup

a0d1409

use shared workflows for node-ci-push

bda10f0

remove coverage job since the test workflow covers it

89c9872

beaesguerra commented Oct 17, 2024

View reviewed changes

beaesguerra mentioned this pull request Oct 17, 2024

Include lint and test jobs for node-ci-push workflow (option 1) #2346

Closed

beaesguerra marked this pull request as ready for review October 17, 2024 21:55

khan-actions-bot requested a review from a team October 17, 2024 21:55

beaesguerra force-pushed the try-workflow branch from 68b5dbd to 89c9872 Compare October 18, 2024 16:06

beaesguerra changed the title ~~Include lint and test jobs for node-cipush workflow (option 2)~~ Include lint and test jobs for node-ci-push workflow (using reusable workflow) Oct 18, 2024

jandrade approved these changes Oct 18, 2024

View reviewed changes

beaesguerra merged commit bb7f7cf into main Oct 18, 2024
65 of 67 checks passed

beaesguerra deleted the try-workflow branch October 18, 2024 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include lint and test jobs for node-ci-push workflow (using reusable workflow) #2348

Include lint and test jobs for node-ci-push workflow (using reusable workflow) #2348

beaesguerra commented Oct 17, 2024 •

edited

Loading

changeset-bot bot commented Oct 17, 2024 •

edited

Loading

beaesguerra Oct 17, 2024

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

beaesguerra Oct 17, 2024

khan-actions-bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

jandrade left a comment

beaesguerra commented Oct 18, 2024

Include lint and test jobs for node-ci-push workflow (using reusable workflow) #2348

Include lint and test jobs for node-ci-push workflow (using reusable workflow) #2348

Conversation

beaesguerra commented Oct 17, 2024 • edited Loading

Summary:

Test plan:

changeset-bot bot commented Oct 17, 2024 • edited Loading

⚠️ No Changeset found

beaesguerra Oct 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

A new build was pushed to Chromatic! 🚀

Chromatic results:

beaesguerra Oct 17, 2024

Choose a reason for hiding this comment

khan-actions-bot commented Oct 17, 2024 • edited Loading

Gerald

github-actions bot commented Oct 17, 2024 • edited Loading

npm Snapshot: NOT Published

jandrade left a comment

Choose a reason for hiding this comment

beaesguerra commented Oct 18, 2024

beaesguerra commented Oct 17, 2024 •

edited

Loading

changeset-bot bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

khan-actions-bot commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading