Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include lint and test jobs for node-ci-push workflow (option 1) #2346

Closed
wants to merge 20 commits into from
Closed

Include lint and test jobs for node-ci-push workflow (option 1) #2346

wants to merge 20 commits into from

Commits on Oct 15, 2024

  1. copy lint and test jobs from node-ci-pr.yml so that checks can be ena… 

    …bled on feature branches (this is so feature branches can be updated with main)
    @beaesguerra
    beaesguerra committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    eb0ecc4 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. set up separate lint workflow and test with pr workflow

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c4dea85 View commit details
    Browse the repository at this point in the history

  2. temporarily disable other pr checks for testing

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    85b247d View commit details
    Browse the repository at this point in the history

  3. add printing message to see if new workflow was used

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    8695578 View commit details
    Browse the repository at this point in the history

  4. fix error

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    979c839 View commit details
    Browse the repository at this point in the history

  5. update name in reusable workflow

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6e587b1 View commit details
    Browse the repository at this point in the history

  6. try reusing an action instead of a workflow so that the check name is… 

    … persisted
    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    85e3439 View commit details
    Browse the repository at this point in the history

  7. fill in lint steps

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    476f17d View commit details
    Browse the repository at this point in the history

  8. fix dir structure

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5804480 View commit details
    Browse the repository at this point in the history

  9. address error with required property is missing: shell

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f77e773 View commit details
    Browse the repository at this point in the history

  10. address error with required property is missing: shell

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b89093b View commit details
    Browse the repository at this point in the history

  11. clean up lint action. things are passing now

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c0a0a52 View commit details
    Browse the repository at this point in the history

  12. remove unneeded workflow file

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2bf0cec View commit details
    Browse the repository at this point in the history

  13. set up test action

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2b8e792 View commit details
    Browse the repository at this point in the history

  14. add shell property and set up codecov secret

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    7c82b21 View commit details
    Browse the repository at this point in the history

  15. debugging

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    22af10e View commit details
    Browse the repository at this point in the history

  16. pass codecov token as an env var since composite actions don't suppor… 

    …t secrets
    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    2ecbd82 View commit details
    Browse the repository at this point in the history

  17. Revert "temporarily disable other pr checks for testing" 

    This reverts commit 85b247d.
    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    339804d View commit details
    Browse the repository at this point in the history

  18. use composite actions in node-ci-push

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    b8e960e View commit details
    Browse the repository at this point in the history

  19. remove coverage job since test action covers coverage too

    @beaesguerra
    beaesguerra committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e2a1fc2 View commit details
    Browse the repository at this point in the history