Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update
Toolbar
to use CSS grid (#2361)
## Summary: This PR makes it so elements passed to the `title` of a `Toolbar` can set `max-width: 100%` to ensure the title never overlaps `leftContent` or `rightContent`. This PR also: - Slightly changes the wrapping behavior of long titles. This is not intended, but it is unavoidable, so I've matched the original behavior as closely as I can. - Makes the spacing more consistent when using responsive buttons that grow to take up the full footer width on mobile in `rightContent`. When we update webapp to use this version, we will need to update the following locations to use `100%` in place of `100vw`: ``` services/static/javascript/content-library/ui/default-content-footer-buttons.tsx: 496: width: "100vw", services/static/javascript/python-coding/python-content-footer.tsx: 124: width: "100vw", services/static/javascript/python-coding/programs/embedded-python-user-program-page.tsx: 140: width: "100vw", services/static/javascript/python-coding/programs/footer.tsx: 300: width: "100vw", services/static/javascript/wonder-blocks-package/wonder-blocks-toolbar.stories.tsx: 18: width: "100vw", ``` Issue: AX-315 ## Test plan: Check out the `Toolbar` stories Author: timmcca-be Reviewers: jandrade, timmcca-be Required Reviewers: Approved By: jandrade Checks: ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ gerald, ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ✅ Chromatic - Get results on regular PRs (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 2/2), ✅ Lint / Lint (ubuntu-latest, 20.x), ✅ Test / Test (ubuntu-latest, 20.x, 1/2), ✅ Check build sizes (ubuntu-latest, 20.x), ✅ Chromatic - Build on regular PRs / chromatic (ubuntu-latest, 20.x), ⏭️ Chromatic - Skip on Release PR (changesets), ⏭️ Publish npm snapshot, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 20.x), ✅ gerald, ⌛ undefined Pull Request URL: #2361
- Loading branch information