[Storybook] Disable snapshots globally + enable for select few stories #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to disable snapshots globally, since most of our stories
don't need visual snapshot testing anyway, and we keep going over
our monthly chromatic snapshot limit.
Instead, we should deliberately set snapshots to true for stories we
want chromatic snapshots for.
- turn off chromatic snapshots globally
- turn on chromatic snapshots for interactive graph stories
Issue: https://khanacademy.atlassian.net/browse/LEMS-2579
Test plan:
Look at the Chromatic snapshots number on this PR below.
Previously, it was over 400. It should be much smaller now.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (7fc1ff9) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1897If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1897 |
|
Size Change: 0 B Total Size: 1.29 MB ℹ️ View Unchanged
|
|
It turns out that we were only supposed to be capturing snapshots for regression stories anyway. For some reason, other stories were still being captured. That means we don't need all the extra enabled stories in this PR, so I'm going to create a new PR for the minimal necessary changes: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We want to disable snapshots globally, since most of our stories
don't need visual snapshot testing anyway, and we keep going over
our monthly chromatic snapshot limit.
Instead, we should deliberately set snapshots to true for stories we
want chromatic snapshots for.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2579
Test plan:
Look at the Chromatic snapshots number on this PR below.