[🔥AUDIT🔥] Target node 12 so we don't break folks that haven't upgraded yet #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: oops! https://khanacademy.slack.com/archives/C02NMB1R5/p1650646528384399 Test plan: run `npm run build`, and switch to node 12 w/ nvm or whatever you've got. `node ./dist/cli/run.js` should work, instead of crashing with a syntax error!
🦋 Changeset detectedLatest commit: 2af0dbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖍 This is an audit! 🖍
Summary:
oops!
https://khanacademy.slack.com/archives/C02NMB1R5/p1650646528384399
Issue: XXX-XXXX
Test plan:
run
npm run build, and switch to node 12 w/ nvm or whatever you've got.node ./dist/cli/run.jsshould work, instead of crashing with a syntax error!Switch back to node 16 and ensure that it also runs fine under 16.