-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gerald for Node 20 #83
Conversation
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to modify the autofix-commit-action bit to use Node 20, or drop that and instead error if things need updating so that the dev just does it locally.
The other node16 warning we're getting is because Gerald is running itself against itself and the version it runs is the one on main
which is, of course, not yet on Node 20. So that should go away when this PR lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you Jeff! You need to mark the .github/workflows
directory as no-longer generated. I think you can change this in the .gitattributes
file, this way the changes will show up in the PR.
Summary:
This updates the
@vercel/ncc
dependency to work with Node 20. It also removes our custom workflow template processing in favour of the newer, idiomatic shared actions approach that GitHub workflows now support. Finally, I tidied up some of the workflows to be a little easier to follow and to drop some steps that seem redundant (line runningyarn global add
without any packages).It seems odd that we run jest twice - we can probably be more idiomatic here and drop our custom actions, only running jest once with coverage.
Issue: FEI-5545
Test plan:
yarn test
yarn build
Push this PR and see what the workflows do.