Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gerald for Node 20 #83

Merged
merged 7 commits into from
Apr 5, 2024
Merged

Update gerald for Node 20 #83

merged 7 commits into from
Apr 5, 2024

Conversation

somewhatabstract
Copy link
Member

@somewhatabstract somewhatabstract commented Apr 4, 2024

Summary:

This updates the @vercel/ncc dependency to work with Node 20. It also removes our custom workflow template processing in favour of the newer, idiomatic shared actions approach that GitHub workflows now support. Finally, I tidied up some of the workflows to be a little easier to follow and to drop some steps that seem redundant (line running yarn global add without any packages).

It seems odd that we run jest twice - we can probably be more idiomatic here and drop our custom actions, only running jest once with coverage.

Issue: FEI-5545

Test plan:

yarn test
yarn build

Push this PR and see what the workflows do.

@somewhatabstract somewhatabstract self-assigned this Apr 4, 2024
@somewhatabstract somewhatabstract requested a review from a team April 4, 2024 19:21
@khan-actions-bot khan-actions-bot requested a review from a team April 4, 2024 19:22
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Apr 4, 2024

Gerald

Required Reviewers
  • @Khan/github-actions for changes to .gitattributes, action.yml, package.json, yarn.lock, dist/index.js, setup-files/gerald-pr.yml, setup-files/gerald-push.yml, .github/workflows/build.yml, .github/workflows/gerald-pr.yml, .github/workflows/gerald-push.yml, .github/workflows/pr-actions.yml, .github/workflows/pr-autofix.yml, .github/actions/setup/action.yml

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Copy link
Member Author

@somewhatabstract somewhatabstract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to modify the autofix-commit-action bit to use Node 20, or drop that and instead error if things need updating so that the dev just does it locally.

The other node16 warning we're getting is because Gerald is running itself against itself and the version it runs is the one on main which is, of course, not yet on Node 20. So that should go away when this PR lands.

Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you Jeff! You need to mark the .github/workflows directory as no-longer generated. I think you can change this in the .gitattributes file, this way the changes will show up in the PR.

@somewhatabstract somewhatabstract merged commit 01a1c01 into main Apr 5, 2024
4 checks passed
@somewhatabstract somewhatabstract deleted the fei5545.1.node20 branch April 5, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants