Cache files library and CLI tool #266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instead of a filename, added a unit test for cache conversion (although i dont know how to run it)
|
|
I've just tried to convert a Kernel Tuner cache file to the T4 format, but the conversion does not yet handle non-valid configurations. This can be seen in |
fjwillemsen
reviewed
Oct 11, 2024
| invalidity = "constraints" | ||
|
|
||
| result = T4ResultLineJSON( | ||
| timestamp=cache_line["timestamp"], |
There was a problem hiding this comment.
This line requires the input cachefile to have timestamps, is that something we want to enforce or are we okay with something like cache_line.get("timestamp", None)?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request restores the accidentally closed pull request #265 that I can't seem to otherwise restore myself. This time its not from a 'master' branch on a fork, but from a branch of our own repository which makes it easier to work with.
To restore the original text of the pull request by @tdejong00:
This pull request adds an interface for modifying cache files, which is located in the
kernel_tuner/cachedirectory. This directory contains the following modules:cache(main module): contains aCacheclass through which cache files can be created, read and written. This should be the only python module that needs to be used for modifying cache files.cli_tools: contains functions used in thektcachecommand.convert: contains functions for converting (older) cache files to newer cache files.file: contains functions for reading JSON from and writing JSON to cache files.json: contains TypeDict type hints for typing code.json_encoder: contains a custom instance of JSONEncoder that automatically serializes data into JSON in a readable format.paths: contains useful paths within the project.versions: exports useful Semver version constants.Furthermore the following test modules have been added:
test_cachefile_class.py: tests whether the class integrates the functionalities of the other cache modules in the correct way and the additional logic in theCacheclass.test_cachefile_encoder.py: tests whether the JSON is encoded in the right way.test_cachefile_read_write.py: tests whether cache is read and written in the correct format.test_cachefile_schema.py: tests the correctness of the schema.test_script_ktcache.py: tests thektcacheCLI command.We have not yet added an entry to the
CHANGELOG.md, because we are not sure in what version these changes will be introduced.