binder_ndk_sys: Allow code to build inside a workspace #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this file is generated into `target/`, it might still think it
belongs to a parent `[workspace]` crate and fail to compile:
Compiling binder_ndk_sys v0.2.0 (binder_rs/binder_ndk_sys)
error: failed to run custom build command for `binder_ndk_sys v0.2.0 (binder_rs/binder_ndk_sys)`
Caused by:
process didn't exit successfully: `my-hidl-crate/target/debug/build/binder_ndk_sys-a839da7d88e99ce9/build-script-build` (exit status: 101)
--- stdout
cargo:rerun-if-changed=src/BinderBindings.hpp
cargo:rerun-if-changed=src/symbols.txt
--- stderr
error: current package believes it's in a workspace when it's not:
current: my-hidl-crate/target/aarch64-linux-android/debug/build/binder_ndk_sys-a3aef417509c2387/out/libbinder_ndk/Cargo.toml
workspace: my-hidl-crate/Cargo.toml
this may be fixable by ensuring that this crate is depended on by the workspace root: my-hidl-crate/Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
Follow the suggestion from `cargo` and turn the generated
`libbinder_ndk/Cargo.toml` crate into a new workspace root.
This would have previously gone unnoticed as the invocation of `cargo
build` did not check whether it had a nonzero exit code: this is now
asserted on too.
We also revert commit 6627342 ("Fix build failed when used in workspace
(Kernel-SU#5)") which was working around the issue _within this repository
only_, but that doesn't apply to users/consumers of this crate via i.e.
crates.io.
MarijnS95
force-pushed
the
fix-workspace-build
branch
from
902226c to
bf8a863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @rsglobal for #9 (comment)
When this file is generated into
target/, it might still think it belongs to a parent[workspace]crate and fail to compile:Follow the suggestion from
cargoand turn the generatedlibbinder_ndk/Cargo.tomlcrate into a new workspace root.This would have previously gone unnoticed as the invocation of
cargo builddid not check whether it had a nonzero exit code: this is now asserted on too.We also revert commit 6627342 ("Fix build failed when used in workspace (#5)") which was working around the issue within this repository only, but that doesn't apply to users/consumers of this crate via i.e. crates.io.