Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/address form component #6

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

xminar1
Copy link
Collaborator

@xminar1 xminar1 commented May 15, 2024

Motivation

A new Address Form Component was added that supports address validation and autocomplete.

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

  • After adding the address field in the Forms application, the field is correctly rendered on the website.
  • Enabling/disabling all of the options for the address field changed the field's behavior correctly.
  • Adding country restriction and suggestions language options correctly changed suggestions and validation.

Test the following scenarios with different options enabled if the result is as expected:

  • User clicks on the current location button with enabled/disabled browser access to the current location.
  • User submits valid address.
  • User submits an invalid address.
  • User submits only a partial address.
  • User submits valid company name.
  • User submits an invalid company name.

xminar1 added 3 commits April 29, 2024 12:57
* Add references and packages

* Add basic form component

* Add initial AddressValidator

* Add geocode request

* Add options and startup extensions

* Add address validation request

* Add missing docs

* Refactor namespaces

* Add SetupExtensions unit tests

* Add AddressValidator unit tests

* Move AssemblyDiscoverable attribute

* Fix urls and remove unused method

* Add validation options to properties

* Change default value for enabling company names

* Add localization of strings

* Improve validation based on granularity

* Change namespace and mothod name in StartupExtensions

* Remove unnecessary Order from address properties

* Add missing checks to address validator

* Fix dependencies

* Split Validator and Geocoder

* Add better error logging

* Refactor tests after sevices split

* Add AddressFormComponent tests

* Add unit test attributes

* Add better error handling

* Add tests for error responses

* Fix folder structure

* Add ValidateInternal method

* Add missing checks and resources

* Improve services error handling
* Add initial script file

* Add script for address fom component

* Refactor javascript file

* Add form component properties

* Add google logo to dropdown

* Add missing resources

* Add missing docs

* Fix resources and js errors

* Improve resource strings

* Improve JS file readability

* Fix multiple countries restrictions

* Add only one coutry support if selected

* Add autocomplete flow improvements
* Add initial ReadMe for integration

* Add section about customization

* Add DancingGoat demo

* Remove AspNetCore app reference

* Improve ReadMe
@xminar1 xminar1 requested a review from seangwright May 15, 2024 12:21
Copy link
Member

@seangwright seangwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

Copy link
Member

@seangwright seangwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@seangwright seangwright merged commit a353a0d into main Jul 22, 2024
1 check passed
@seangwright seangwright deleted the feature/Address_form_component branch July 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants