Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: future/nsaktaganov #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nurzhan-saktaganov
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.75472% with 42 lines in your changes missing coverage. Please review.

Project coverage is 68.17%. Comparing base (d6277d5) to head (1933cc6).

Files with missing lines Patch % Lines
api.go 26.82% 30 Missing ⚠️
error.go 0.00% 8 Missing ⚠️
discovery.go 0.00% 3 Missing ⚠️
vshard.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   69.92%   68.17%   -1.75%     
==========================================
  Files          13       13              
  Lines        1260     1285      +25     
==========================================
- Hits          881      876       -5     
- Misses        331      361      +30     
  Partials       48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fix decoding fields for StorageCallVShardError (MasterUUID, ReplicasetUUID).
* add ReplicaUUID to the StorageCallVShardError struct.
* use constants for vshard error names.
* add comment why and how we handle "NON_MASTER" vshard error.
@nurzhan-saktaganov nurzhan-saktaganov force-pushed the future/nsaktaganov branch 2 times, most recently from e81ae86 to e60b83f Compare November 8, 2024 12:45
* handle vshard error the same way as lua vshard router.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants