Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure timezone differences #20

Closed
wants to merge 1 commit into from

Conversation

laenas
Copy link

@laenas laenas commented Aug 17, 2021

This should resolve #13

I touched up some incidental code along the path I needed to tweak anyway. There's a breaking change to the full-name versions of the commandline option for the csv file, but it's counterbalanced by offering single-letter version which is quicker.

@Kavignon
Copy link
Owner

What is the breaking change? Can you share a screenshot of before/after? :)

Thank you for this contribution; I think the tool is getting way more awesome than it used to be!

@laenas
Copy link
Author

laenas commented Aug 17, 2021

What is the breaking change? Can you share a screenshot of before/after? :)

Argu by default will use the case name, with some normalization rules, to produce commandline switches. As such, the previous invocation of the application would require .\MentorMatchmaker.exe -creatementorshipmatches .\mentorshipdata.csv

Since I needed to add another commandline option anyway, I modified that flag so that it can now be invoked as either --csv or -c

@laenas laenas closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement: Adapt the matcher so we only match people that are within a certain timezone margin
2 participants