Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not double-escape * during package update #11273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hairmare
Copy link

What are the changes introduced in this pull request?

Update the "Update packages by search query - Katello Ansible Default" template to pass a simple * instead of "*" to the upstream "Package Action - Ansible Default" template. This makes it possible to upgrade all packages via Ansible using Katello 4.14 (and other versions).

The current template is erroring out:

fatal: [test-vm-01.example.org]: FAILED! => {"changed": false, "failures": ["No package \"*\" available."], "msg": "Failed to install some of the specified packages", "rc": 1, "results": []}

Considerations taken when implementing this change?

  • I tried to fix this as early as possible in the template call tree, to keep the change as minimal as possible.
  • The change has been working well on my production for a while. Most likely other users have heavier customizations to the scripts.

What are the testing steps for this pull request?

  1. Configure Foreman/Katello to use Ansible for all actions
  2. Select all upgradable packages for a host in the UI, and "Upgrade" all the packages through REX
  3. It updates all packages and doesn't fail

@hairmare hairmare marked this pull request as ready for review December 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant