Fixes #38112 - Order LCEs by LCE path in Content View GUI and Hammer #11267
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylenz
reviewed
Dec 18, 2024
Comment on lines
112
to
114
| content_view_environments = organization.readable_promotion_paths.flatten | ||
| content_view_environments.insert(0, organization.library) | ||
| content_view_environments.intersection(environments) |
There was a problem hiding this comment.
Aren't these KTEnvironments and not Katello::ContentViewEnvironments?
There was a problem hiding this comment.
Renaming the variable will help here..The content_view_environments should be something like organization_readable_environments
jeremylenz
reviewed
Dec 18, 2024
| @@ -49,7 +49,7 @@ end | |||
| extends 'katello/api/v2/common/timestamps' | |||
|
|
|||
| version = @object || @resource | |||
| child :environments => :environments do | |||
| child :sorted_content_view_environments => :environments do | |||
There was a problem hiding this comment.
I don't think these are content view environments either..
There was a problem hiding this comment.
I have renamed at both the places with the name suggested by @sjha4
pavanshekar
force-pushed
the
issue-38112
branch
from
2ee377e to
3340d09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Updated the ContentView and ContentViewVersion models to order LCEs based on their promotion paths in both the GUI Content View page and the Hammer CLI. The API response was updated to reflect the new ordering, providing consistency across interfaces.
Considerations taken when implementing this change?
Optimized the changes to minimize performance impact while maintaining backward compatibility to ensure existing functionality remains unaffected. Ensured consistency across the GUI and Hammer CLI with thorough testing to validate correct behavior. Designed the implementation to be modular and maintainable for future updates.
What are the testing steps for this pull request?