Fixes #38097 - Add packages count to new All Hosts page #11260
Merged
+40
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremylenz Do you have any thoughts about the implementation? |
jeremylenz
approved these changes
Dec 13, 2024
nadjaheitmann
force-pushed
the
38097_deb_count
branch
2 times, most recently
from
8f3cb72 to
44a84cd
Compare
|
Thanks! I restructured the code for the rabl files a bit. Not sure if it got better, though :) Maybe a bit as the code in os_attributes.json.rabl is not duplicated in the show.json.rabl anymore. |
nadjaheitmann
force-pushed
the
38097_deb_count
branch
from
44a84cd to
f5d5c38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
The package count on the new All hosts page does not work. This PR aims to fix this.
Considerations taken when implementing this change?
Errata is not available for Debian, so it is okay for those fields to show 0.
What are the testing steps for this pull request?
You need a Debain package on a host that can is upgradable.