Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oncokb deletion #220

Open
jkobject opened this issue Apr 8, 2022 · 5 comments
Open

Oncokb deletion #220

jkobject opened this issue Apr 8, 2022 · 5 comments
Assignees

Comments

@jkobject
Copy link

jkobject commented Apr 8, 2022

Hi!

Thank you for the great tool!
I am wondering why you have recently removed oncoKB. (This is a really useful annotator for us at DepMap)

Best,

@rkimoakbioinformatics
Copy link
Contributor

@jkobject Sorry, it must have been a mistake. It has been restored.

@jkobject
Copy link
Author

Hi!

I might not really understand how this repo work because oncoKB I don't see reverts on the master branch so oncokb seems to still be absent from this repo.

I tried to run the oncokb annotator a couple days ago and it seems to have returned null for every mutations (which seems unlikely).

@mryaninsilico
Copy link
Contributor

mryaninsilico commented Apr 12, 2022 via email

@jkobject
Copy link
Author

jkobject commented May 26, 2022

Thanks for the help,

Should I ask my next question on the open Cravat's main repo?

I have ran the annotation with oncokb, listed the keyfile in the right folder, oncokb annotator ran for a long time and the output vcf was annotated but I see every mutations in the file having the exact same annotation: OC_oncokb__oncogenic=Unknown;OC_oncokb__knownEffect=Unknown

Moreover, it seems that oncokb is very slow (takes 2 days to annotate one WGS file)... We have thousands that we would want to annotate.

My guess is that it can only happen if you are making requests to the API for every mutations?

Would there be a way to make this process much faster?

  1. keeping a record of oncoKB's annotations? or
  2. only running it on coding regions? (it seems oncoKB only has annotation for these)

What do you think?

@drstormR
Copy link

Hi,
Did you find a solution for using OncoKB module with OpenCravat? I have the same issue, it's running extremely slow.

Thanks

@jasminebro jasminebro transferred this issue from KarchinLab/open-cravat-modules-karchinlab Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants