Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git action failed on Windows when building shared library #29

Merged

Conversation

Nonumx
Copy link
Collaborator

@Nonumx Nonumx commented May 7, 2024

GTest working directory has been changed to build/lib.

See #22.

@Nonumx Nonumx requested a review from Kaiser-Yang May 7, 2024 07:13
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@bf4ce27). Click here to learn what that means.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kaiser-Yang Kaiser-Yang force-pushed the 22-fix-git-action-on-windows-when-build-shared-library branch 2 times, most recently from dcec852 to 327e731 Compare May 7, 2024 12:37
Update cmake build action config, now when build in `VS`, `gtest` will
be running at
`${CMAKE_BINARY_DIR}/${LIBRARY_OUTPUT_PATH}/${CMAKE_BUILD_TYPE}`, but
when the config is not same with `${CMAKE_BUILD_TYPE}`, there will still
be a problem. So users must copy the libs or specify `PAHT`.
@Kaiser-Yang Kaiser-Yang force-pushed the 22-fix-git-action-on-windows-when-build-shared-library branch from 327e731 to 5723c27 Compare May 7, 2024 12:48
@Kaiser-Yang Kaiser-Yang added the bug Something isn't working label May 7, 2024
@Kaiser-Yang Kaiser-Yang requested a review from Quentin9922 May 7, 2024 12:50
@Quentin9922 Quentin9922 merged commit 1d54f5b into develop May 7, 2024
9 checks passed
@Quentin9922 Quentin9922 deleted the 22-fix-git-action-on-windows-when-build-shared-library branch May 7, 2024 12:53
@Kaiser-Yang Kaiser-Yang linked an issue May 7, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix git action on windows when build shared library
4 participants