Skip to content

Commit

Permalink
fix: do not kill tendermint process
Browse files Browse the repository at this point in the history
  • Loading branch information
troykessler committed Nov 25, 2024
1 parent 937cdaa commit ff27b4a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ require (
github.com/cosmos/gogoproto v1.4.11
github.com/go-git/go-git/v5 v5.11.0
github.com/gofrs/uuid v4.4.0+incompatible
github.com/gogo/protobuf v1.3.2
github.com/google/uuid v1.4.0
github.com/oasisprotocol/curve25519-voi v0.0.0-20220708102147-0a8a51822cae
github.com/vektra/mockery/v2 v2.23.1
Expand Down Expand Up @@ -137,7 +138,6 @@ require (
github.com/gobwas/glob v0.2.3 // indirect
github.com/gofrs/flock v0.8.1 // indirect
github.com/gofrs/uuid/v5 v5.0.0 // indirect
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/glog v1.1.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/golang/snappy v0.0.4 // indirect
Expand Down
10 changes: 5 additions & 5 deletions proxy/multi_app_conn.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import (

abcicli "github.com/KYVENetwork/cometbft/v38/abci/client"
cmtlog "github.com/KYVENetwork/cometbft/v38/libs/log"
cmtos "github.com/KYVENetwork/cometbft/v38/libs/os"
"github.com/KYVENetwork/cometbft/v38/libs/service"
)

Expand Down Expand Up @@ -131,10 +130,11 @@ func (app *multiAppConn) killTMOnClientError() {
logger.Error(
fmt.Sprintf("%s connection terminated. Did the application crash? Please restart CometBFT", conn),
"err", err)
killErr := cmtos.Kill()
if killErr != nil {
logger.Error("Failed to kill this process - please do so manually", "err", killErr)
}
// Do not kill tendermint process to enable KSYNC to continue running during upgrades
//killErr := cmtos.Kill()
//if killErr != nil {
// logger.Error("Failed to kill this process - please do so manually", "err", killErr)
//}
}

select {
Expand Down

0 comments on commit ff27b4a

Please sign in to comment.