Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean #13

Merged
merged 27 commits into from
May 6, 2024
Merged

Clean #13

merged 27 commits into from
May 6, 2024

Commits on May 5, 2024

  1. Do not use Roxygen comment for separator line

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    b2f7c65 View commit details
    Browse the repository at this point in the history

  2. Integrate pattern directly in grepl() call

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    18a12e8 View commit details
    Browse the repository at this point in the history

  3. Improve indentation

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    0e15004 View commit details
    Browse the repository at this point in the history

  4. Use new function formattedMessageIf()

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    5da4fc0 View commit details
    Browse the repository at this point in the history

  5. Rename arg "version_dates" to "versions" 

    and use new helper function splitBy()
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f8961b1 View commit details
    Browse the repository at this point in the history

  6. Simplify Roxygen documentation

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    6a8fbc2 View commit details
    Browse the repository at this point in the history

  7. Integrate URL pattern in sprintf() call 

    and use selectColumns()
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    4e3688e View commit details
    Browse the repository at this point in the history

  8. Add utility functions copyFile(), downloadFile()

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    abaae92 View commit details
    Browse the repository at this point in the history

  9. Document and export loadDescriptionFromWeb() 

    and use selectColumns()
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    69ec6dd View commit details
    Browse the repository at this point in the history

  10. Clean readGithubPackageDescription() 

    - improve names
- avoid helper variable "contentLines"
- use new helper functions
  - readDescriptionAddingPath()
  - copyFile()
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    995985a View commit details
    Browse the repository at this point in the history

  11. Clean/simplify loadDescriptionFromArchiveUrl() 

    - Integrate and remove
  - untarDescriptionFromUrl(),
  - pathDescription()
- use new helper functions
  - downloadFile()
  - copyFile(),
  - readDescriptionAddingPath()
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    c1d1684 View commit details
    Browse the repository at this point in the history

  12. Remove tests of deleted functions 

    and update the NAMESPACE file
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    047296a View commit details
    Browse the repository at this point in the history

  13. Improve names, implement simple test

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    6467734 View commit details
    Browse the repository at this point in the history

  14. Clean archivedCranVersions() 

    - integrate getLastVersionBefore()
- rename "src" to "text"
- compose the pattern
- use magrittr pipe
    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    a4d5ff2 View commit details
    Browse the repository at this point in the history

  15. Use copyFile(), let it return all file paths

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    ccba59a View commit details
    Browse the repository at this point in the history

  16. Rename "src" to "text"

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    802fe8b View commit details
    Browse the repository at this point in the history

  17. Use pipe operator, add tests

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    172067b View commit details
    Browse the repository at this point in the history

  18. Clean detach.R

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    f1a2d08 View commit details
    Browse the repository at this point in the history

  19. Clean and test downloadGitHubPackage()

    @hsonne
    hsonne committed May 5, 2024
    Configuration menu
    Copy the full SHA
    bc565ac View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Use intermediate variable "versionInDescription"

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f619301 View commit details
    Browse the repository at this point in the history

  2. Use sprintf() and pipe operator

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    46fe9c4 View commit details
    Browse the repository at this point in the history

  3. Use pipe operator

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4ae4298 View commit details
    Browse the repository at this point in the history

  4. Use functions from kwb.utils and pipe operator

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    e398130 View commit details
    Browse the repository at this point in the history

  5. Update Rd files

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4446f20 View commit details
    Browse the repository at this point in the history

  6. Support 2nd version of currentCranVersion() 

    and clean a bit (e.g. use more pipes)
    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    bd132e4 View commit details
    Browse the repository at this point in the history

  7. Do not convert "package" to a factor

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    a6dbfb1 View commit details
    Browse the repository at this point in the history

  8. Further cleaning

    @hsonne
    hsonne committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d6c0709 View commit details
    Browse the repository at this point in the history