Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recommend outdated/incompatible mods #2990

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Don't recommend outdated/incompatible mods #2990

merged 4 commits into from
Aug 12, 2024

Conversation

Clayell
Copy link
Contributor

@Clayell Clayell commented Aug 5, 2024

@Capkirk123
Copy link
Member

RCS Build aid changes seem fine. TACLS and RemoteTech are nominally still supported by RealismOverhaul, however. It's just RP-1 that absolutely does not work with them, which I believe has already been configured as such.

@Clayell
Copy link
Contributor Author

Clayell commented Aug 5, 2024

RCS Build aid changes seem fine. TACLS and RemoteTech are nominally still supported by RealismOverhaul, however. It's just RP-1 that absolutely does not work with them, which I believe has already been configured as such.

Perhaps we can put them both as 'supports' instead of recommends? (as 'any of')

@siimav
Copy link
Contributor

siimav commented Aug 11, 2024

Perhaps we can put them both as 'supports' instead of recommends? (as 'any of')

I don't get what's the idea behind this. We do recommend that the player has a comms and a life support mod installed.
While TACLS and RT may be outdated, they're still supported on RO installs. It isn't up to RO to police any of this. Instead we have Express Install that lists the mods we think would be best for most players.

@Clayell
Copy link
Contributor Author

Clayell commented Aug 11, 2024

We do recommend that the player has a comms and a life support mod installed.

Ah, ok now I get the reasoning behind this, I understand. I will revert them to how they were before.

Sorry for bugging you more, but do you mind checking KSP-RO/RP-1-ExpressInstall#6? In my opinion thats a more urgent pr than this. (as in it fixes a ckan issue) (again sorry, ik im not obligated to have you do anything but people keep complaining about KER getting denied by ckan and I feel bad)

@siimav siimav merged commit 27ad8cc into KSP-RO:master Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants