Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force_v for RasterPropMonitor-Core #10217

Merged
merged 1 commit into from
Sep 17, 2024
Merged

force_v for RasterPropMonitor-Core #10217

merged 1 commit into from
Sep 17, 2024

Conversation

HebaruSan
Copy link
Member

image

The v prefix has been dropped on GitHub:

image

image

Now the bot will add it.

@HebaruSan HebaruSan merged commit 288e943 into master Sep 17, 2024
1 check passed
@HebaruSan HebaruSan deleted the fix/rpm-core-v branch September 17, 2024 01:11
@JonnyOThan
Copy link
Contributor

This seems fine, or I could update KSPBuildTools with an option to include a ‘v’ prefix..but I’m not sure I understand all the nuances here. Would it be more straightforward if the bot just ignored a leading ‘v’ ?

Or would it make more sense to just bump the epoch?

@HebaruSan
Copy link
Member Author

update KSPBuildTools with an option to include a ‘v’ prefix

That's probably a good option to have in general. A lot of mods have a history of v1.2.3 formatting because GitHub either suggests it or used to suggest it in the repo creation page (I think because a purely numeric Git tag could be ambiguous, or something?), and consistency is always a plus.

@JonnyOThan
Copy link
Contributor

Drew is working on some stuff for creating a release from a git tag, so people who use that option should be fine as long as they're consistent. It's probably better overall but there's a few more things that need to get ironed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants