Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing the use of github by CKAN due development cycle constraints. #10216

Merged

Conversation

Lisias
Copy link
Contributor

@Lisias Lisias commented Sep 16, 2024

All of these are available on archive org anyway.

Thankyou.

@HebaruSan
Copy link
Member

Hi @Lisias, thanks for reaching out.

Can I ask what sort of "development cycle constraints" are of concern here? Maybe we can adjust CKAN and/or the bot to accommodate them, so as to keep the most reliable hosting options available to users.

Thanks!

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

I had explained it on Forum, and I would prefer not to repeat the same information:

Only what I publish on SpaceDock (and are mirrored on https://archive.org/details/kspckanmods ) are tested and validated to be used by CKAN users.

@HebaruSan
Copy link
Member

I see. That's why I was asking, because I replied in response to those concerns noting that the bot will handle that pipeline appropriately. I hope that was a relief to find out!

So should we close this?

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

After merging it, for sure!

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

Please be advised that packages from github will not work on CKAN anymore.

@HebaruSan
Copy link
Member

Please be advised that packages from github will not work on CKAN anymore.

This response is unclear to me. Could you please explain what you mean?

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

This response is unclear to me. Could you please explain what you mean?

github packages are not meant to be used by CKAN. CKAN users downloading from github will not be able to use it.

Only what's published on SpaceDock and on the Archive mirror will work with CKAN.

@HebaruSan
Copy link
Member

HebaruSan commented Sep 16, 2024

What do you mean by "[they] will not be able to use it"? What will happen if they try?

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

What do you mean by "they will not be able to use it"? What will happen if they try?

I will send them to CKAN page for support.

@HebaruSan
Copy link
Member

HebaruSan commented Sep 16, 2024

You skipped ahead a few steps there, I think. Let's go one at a time.

A user installs a GitHub release via CKAN and starts the game. So far they are not asking anyone for support. What are you expecting to happen next?

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

You skipped ahead a few steps there, I think. Let's go one at a time.

A user installs GitHub release via CKAN and starts the game. So far they are not asking anyone for support. What are you expecting to happen next?

A pop message telling the user to use SpaceDock (or the copy n the Archive Mirror), or they will not be able to load their savegames.

@HebaruSan

This comment was marked as outdated.

@JonnyOThan
Copy link
Contributor

Hey I'm gonna go ahead and merge this now - it's exactly what I asked for on the forum and I think we should let mod authors control decisions about how their mods are distributed.

Committed (I goofed on the commit message, sorry): 146a722

@Lisias
Copy link
Contributor Author

Lisias commented Sep 16, 2024

Thank you, and I apologize if I sounded harsh on Forum. I spent a good part of the weekend chasing ghosts, and I probably let the frustration leak out before being aware of, well, being frustrated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants