Stabilize SourceForge mirror, Cmdline export fixes and modpack format #4174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since #4172 added support for SourceForge krefs and KSP-CKAN/KSP2-NetKAN#183 indexed one, KSP2 mod
KSRe
'sdownload
property has been switching from one mirror host to another at every inflation:Changes
Now Netkan always uses the
psychz
mirror for SourceForge downloads since it is in a central, densely populated location.https://sourceforge.net/p/forge/documentation/Mirrors/
Side fixes
While working on the above, a few additional small things came up:
CkanModule.MetadataEqual
, but theinstall_size
is. This could mean that a user would not be prompted to reinstall a re-uploaded mod if the new ZIP had the same file size but different hashes.Now the hashes are also checked.
ckan list --export
had several quirks:--help
info said it accepts a format parameter without saying what the allowed values were.Now it mentions the allowed values.
Now
--export ckan
does this.csv
andtsv
formats were missing three columns because we were using a format string that had to be updated every time a column was updated, and it wasn't.Now we use
string.Join
instead and it works better.