Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize SourceForge mirror, Cmdline export fixes and modpack format #4174

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Sep 5, 2024

Motivation

Since #4172 added support for SourceForge krefs and KSP-CKAN/KSP2-NetKAN#183 indexed one, KSP2 mod KSRe's download property has been switching from one mirror host to another at every inflation:

image

Changes

Now Netkan always uses the psychz mirror for SourceForge downloads since it is in a central, densely populated location.

https://sourceforge.net/p/forge/documentation/Mirrors/

Side fixes

While working on the above, a few additional small things came up:

  • The SHA1 and SHA256 download hashes aren't considered in CkanModule.MetadataEqual, but the install_size is. This could mean that a user would not be prompted to reinstall a re-uploaded mod if the new ZIP had the same file size but different hashes.
    Now the hashes are also checked.
  • ckan list --export had several quirks:
    • The --help info said it accepts a format parameter without saying what the allowed values were.
      Now it mentions the allowed values.
    • There was no way to export a .ckan modpack file even though this is the most popular format.
      Now --export ckan does this.
    • The csv and tsv formats were missing three columns because we were using a format string that had to be updated every time a column was updated, and it wasn't.
      Now we use string.Join instead and it works better.

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality Easy This is easy to fix Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Netkan Issues affecting the netkan data Network Issues affecting internet connections of CKAN labels Sep 5, 2024
@HebaruSan

This comment was marked as resolved.

@HebaruSan HebaruSan merged commit 3f578cc into KSP-CKAN:master Sep 5, 2024
3 of 4 checks passed
@HebaruSan HebaruSan deleted the fix/sourceforge-mirrors branch September 5, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Cmdline Issues affecting the command line Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Netkan Issues affecting the netkan data Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant