One concurrent download per host for all hosts #3557
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In #3054 we changed the async downloader to sequentialize downloads from GitHub to avoid triggering GitHub's download throttling. Only one GitHub download will ever be active concurrently, and this seems to have solved the problems we were having with throttling.
Problems
Mono.Unix.UnixIOException
can be thrown if there are many concurrent downloads in progress (see [Bug][Solved] Mono.Unix.UnixIOException: Resource temporarily unavailable on Arch Linux after Util.Invoke and long chain of runtime calls #3343 and Download fails and crashes ckan with FATAL UNHANDLED EXCEPTION (Mono.Unix.UnixIOException: Resource temporarily unavailable [EWOULDBLOCK]) #3555).Causes
Changes
Now the single concurrent download behavior is applied to all download hosts, per host. When you start a large group of downloads, we will start one from each host in the group (GitHub, SpaceDock, etc.) in parallel, and as each download finishes the next one from that host will be started, until they're all done. This should fix problems arising from too many downloads from one host.
Fixes #3314 (probably, depending on which downloads were failing for that user).
Fixes #3555 (hopefully, by reducing the number of GUI updates during downloads).