Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR] Service Improvement #18

Merged
merged 14 commits into from
Nov 19, 2024
Merged

[PR] Service Improvement #18

merged 14 commits into from
Nov 19, 2024

Conversation

doyoonkim3312
Copy link
Member

Service Improvement

  • Reflect user feedback received during the closed test.
    1. Add Image to DetailedContent Composable. (If there is an Image resource with no body text, DetailedContent Composable shows empty box.)
    2. Add Skeleton Loader effect to DetailedContent Composable. (Custom defined composable - LazyText - has been used.)
  • Refactor code for better performance.

doyoonkim3312 and others added 14 commits November 17, 2024 23:38
@doyoonkim3312
Merge pull request #17 from KNUTICE/main
c71d6dc 
PR: Customer Service Feature
@doyoonkim3312
[REFACTOR] Restore smallIcon resource
1e5d872 
  - Restore small icon resource for push notification. (It occasionally causes exception.)
@doyoonkim3312
[REFACTOR] Change Coroutine Scope.
7e234fb 
  - Change CoroutineScope to viewModelScope, which belongs to the lifecycle of the ViewModel
@doyoonkim3312
[FEAT] Include Image to DetailedContent Composable
f4b5ab8 
  - DetailedContent Composable would now have an image resource as well. (Prevent empty screen, when the notice only contains Image without its body paragraph.)
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
9722bf0 
  - Isolate AnimatedGradient composable for future use. (increase reusability)
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
d59e194 
  - Manage color being used in Animated Gradients as a resource.
  - Adjust colors for better visibility.
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
59924e1 
  - Replace existing normal text composable with custom defined LazyText composable.
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
d2c19eb 
  - Add new ui state isLoaded for using LazyText.
  - Appropriate adjustment has been made on ViewModel side as well.
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
82244c7 
  - Relocate AnimatedGradient to individual file.
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
94edc06 
  - Add color resources to Color Scheme for better access.
@doyoonkim3312
[REFACTOR] Integrate AnimatedGradient Effect with Text Composable
6ef0735 
  - LazyText is designed to display a placeholder animation while the text to be shown is being loaded.
@doyoonkim3312
[CHORE] Remove Unnecessary Import Statement.
6f04fc7 
  - Remove Unnecessary Import Statement.
@doyoonkim3312
[CHORE] Cleaning up
a355896 
  - Clean up the code, including remove unnecessary import statement, unused parameter values.
@doyoonkim3312
[CHORE] Update Version Information
df7a166 
  - Update Version Information (Beta 1.0.0 RC 4)
@doyoonkim3312
Copy link
Member Author

Proceed to merge.

@doyoonkim3312 doyoonkim3312 merged commit 8cea15d into main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doyoonkim3312