PR: Notification Management feature #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add necessary resources (string, drawable).
- Apply new destination 'OSS' for handling back button action.
- Add new destination 'OSS' for access OpenSourceLicenseNotice composable.
- Composable with a single WebView inflated on specific composable 'AndroidView' for displaying web content directly.
- Add new enum value in enum class Destination. (New destination in Navigator.)
- Replace dummy 'forward' arrow with active Icon Button with appropriate action.
- Remove unnecessary import statement.
- Allow user to manage notification permission.
Permission management would be delegated to system settings.
- Add necessary clean-up tasks, which would be executed when the application is entering onDestroy status.
|
Include OSS composable as well. |
- Modify color applied on Surface to match its color to overall application theme.
|
Proceed to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification management would be delegated to system settings.