Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/#104 #105

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Issue/#104 #105

merged 6 commits into from
Oct 7, 2024

Conversation

momnpa333
Copy link
Collaborator

๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

์ด๋ฏธ์ง€ ์ฒจ๋ถ€

To Reviewers ๐Ÿ“ข

์ฒดํฌ ๋ฆฌ์ŠคํŠธ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ํ…Œ์ŠคํŠธ๋ฅผ ํ†ต๊ณผํ–ˆ์Šต๋‹ˆ๋‹ค.
  • API ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • API ํ˜ธ์ถœ์„ ์ง์ ‘ ์‹ค์‹œํ•˜์˜€๊ณ , ํ•ด๋‹น ๋ฐ์ดํ„ฐ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ํ‘œ์‹œ๋ฉ๋‹ˆ๋‹ค.
  • ๊ธฐ์กด ์ฝ”๋“œ์— ์˜ํ–ฅ์„ ์ฃผ๋Š” ์ž‘์—… ๋‚ด์šฉ์ด ์กด์žฌํ•ฉ๋‹ˆ๋‹ค.
  • ํ–ฅํ›„ ์ถ”๊ฐ€์ ์ธ ์ž‘์—…์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค.

โž• ๊ด€๋ จ ์ด์Šˆ

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

Unit Test Results

33 testsโ€‚โ€ƒโ€ƒ33 โœ”๏ธโ€ƒโ€ƒ2s โฑ๏ธ
11 suitesโ€ƒโ€ƒโŸโ€„0 ๐Ÿ’ค
11 filesโ€„โ€‚โ€ƒโ€ƒโŸโ€„0 โŒ

Results for commit 5290a36.

bayy1216
bayy1216 approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@bayy1216 bayy1216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ”ฅ

@momnpa333 momnpa333 merged commit df00519 into main Oct 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayy1216 bayy1216 bayy1216 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋‚ด ๋žญํ‚น ๋ณด๊ธฐ api
2 participants
@momnpa333 @bayy1216