2주차 다운 #10
Open
2주차 다운 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
죄송합니다.. 담부터 커밋 잘할게요..
양방향 및 단방향 둘다 삭제 가능하게 구현
양방향 및 단방향 둘다 삭제 가능하게 구현
양방향 및 단방향 둘다 삭제 가능하게 구현
bayy1216
approved these changes
May 11, 2024
| } catch (SecurityException | MalformedJwtException | ExpiredJwtException | | ||
| UnsupportedJwtException | | ||
| IllegalArgumentException e) { | ||
| throw e; |
There was a problem hiding this comment.
throw error 하나로 추상화하는거 어떤가요?
| @Slf4j | ||
| @RequiredArgsConstructor | ||
| @PropertySource("classpath:application.yml") | ||
| public class OAuthService { |
| this.expirationPeriod = expirationPeriod; | ||
| } | ||
|
|
||
| public static GifticonResponse from(final Gifticon gifticon){ |
| /** | ||
| * 재고 증가 | ||
| */ | ||
| public void addStock(Long quantity) { |
| this.owner = owner; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
validCheck private메소드로 뺴는거도 좋을거같아요
| throw new IllegalArgumentException("브랜드는 필수 입력 값입니다."); | ||
| } | ||
| if(gifticonUpdate.getDescription() != null && gifticonUpdate.getDescription().isBlank()){ | ||
| throw new IllegalArgumentException("설명은 필수 입력 값입니다."); |
There was a problem hiding this comment.
jakerta에서 Validator있는데 이거 쓰는거도 고려해보세용
| */ | ||
| public PagingResponse<FundingArticleResponse> getFundingArticlePaging( | ||
| PagingRequest pagingRequest) { | ||
| return PagingResponse.from(fundingArticleJpaRepository.findAll(pagingRequest.toPageable()), |
There was a problem hiding this comment.
리턴할때 메소드 한방에하는거보다 나눠서 쓰는거는 어떤가요?
| public void deleteGifticon(Long gifticonId){ | ||
| //상품이 있는지 확인 | ||
| Gifticon findGifticon = gifticonJpaRepository.findById(gifticonId).orElse(null); | ||
| if(findGifticon == null){ |
fanta4715
reviewed
May 11, 2024
Comment on lines
+16
to
+33
| public class UserGifticonService { | ||
| private final UserGifticonJpaRepository userGifticonJpaRepository; | ||
|
|
||
| /** | ||
| * 유저기프티콘 전체 조회 | ||
| */ | ||
| public List<UserGifticon> findUserGifticonAll() | ||
| { | ||
| return userGifticonJpaRepository.findAll(); | ||
| } | ||
|
|
||
| /** | ||
| * 유저기프티콘 상세 조회 | ||
| */ | ||
| public UserGifticon findUserGifticon(Long userGifticonId) | ||
| { | ||
| return userGifticonJpaRepository.findById(userGifticonId).orElse(null); | ||
| } |
Comment on lines
+74
to
+91
| public void addStock(Long gifticonId, Long stock){ | ||
| Gifticon findGifticon = gifticonJpaRepository.findById(gifticonId).orElse(null); | ||
| if(findGifticon == null){ | ||
| throw new NotFoundGifticonException("해당 상품이 존재하지 않습니다."); | ||
| } | ||
| findGifticon.addStock(stock); | ||
| } | ||
|
|
||
| /** | ||
| * 재고 감소 | ||
| */ | ||
| @Transactional | ||
| public void removeStock(Long gifticonId, Long stock){ | ||
| Gifticon findGifticon = gifticonJpaRepository.findById(gifticonId).orElse(null); | ||
| if(findGifticon == null){ | ||
| throw new NotFoundGifticonException("해당 상품이 존재하지 않습니다."); | ||
| } | ||
| findGifticon.removeStock(stock); |
There was a problem hiding this comment.
재고에 동시성 이슈가 발생할 것 같습니다!
Comment on lines
+54
to
+56
| List<Gifticon> gifticons = gifticonIds.stream() | ||
| .map(gifticonId -> gifticonJpaRepository.findById(gifticonId).orElseThrow()) | ||
| .toList(); |
There was a problem hiding this comment.
JPA메소드에 findByIdIn 쓰면 한 번에 가져오기 편할 거 같아요
가져오고 나서, 리스트 사이즈가 pk리스트 사이즈랑 같은 지 판별하면 굿
Comment on lines
+49
to
+54
| UserGifticon userGifticon = new UserGifticon(); | ||
| userGifticon.buyer = gifticonPurchase.getBuyer(); | ||
| userGifticon.owner = gifticonPurchase.getOwner(); | ||
| userGifticon.gifticon = gifticonPurchase.getGifticon(); | ||
| userGifticon.purchaseDate = gifticonPurchase.getPurchaseDate(); | ||
| userGifticon.expirationDate = gifticonPurchase.getExpirationDate(); |
There was a problem hiding this comment.
Filter는 configurage가 아닌데 여기 폴더에 있네요
저번주에 저가 지적받은 부분이라 남겨둡ㄴ디ㅏ
| .sessionCreationPolicy(SessionCreationPolicy.STATELESS)) | ||
| .authorizeHttpRequests(authReq -> authReq | ||
| .requestMatchers(HttpMethod.OPTIONS).permitAll() | ||
| .requestMatchers("/", "/login", "/oauth2/**", "/refresh","/swagger-ui/**","/api-docs","/v3/api-docs/**").permitAll() |
There was a problem hiding this comment.
위에 WHITELIST 정의하셨는데 url 목록을 이걸로 대체할 수 있을꺼 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
죄송합니다..