PREVIEW changes to support external signature devices #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rp-net6 # Conflicts: # src/Directory.Packages.props # src/foundation/src/PDFsharp/src/PdfSharp-gdi/PdfSharp-gdi.csproj # src/foundation/src/PDFsharp/src/PdfSharp-wpf/PdfSharp-wpf.csproj # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.AcroForms/PdfAcroField.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.AcroForms/PdfSignatureField.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.Advanced/PdfCatalog.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.Advanced/PdfCrossReferenceTable.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.Annotations/IAnnotationAppearanceHandler.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.IO/PdfReader.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.IO/PdfWriter.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf.Signatures/DefaultSignatureAppearanceHandler.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf/PdfDictionary.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf/PdfDocument.cs # src/foundation/src/PDFsharp/src/PdfSharp/Pdf/PdfPage.cs
Havunen
commented
Oct 30, 2024
| /// <param name="modified"></param> | ||
| internal void SetModified(bool modified) | ||
| { | ||
| if (Owner == null || !Owner.IsAppending || !Owner.IrefTable.FullyLoaded) |
There was a problem hiding this comment.
I believe this null check should not be here otherwise the IrefTable is not updated
There was a problem hiding this comment.
Not sure if i get your point here, you mean the if (Owner == null - check ?
The code would crash without it (on the Owner.IsAppending statement)
There was a problem hiding this comment.
To me it feels that we should ensure owner is never null rather than null check here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made on top of PDFSharp 6.2 prev1 + KDS:signature-feature + Packadats incremental save
It might be easier to check the changes in my repositorys commit history due to so many files being changed here
After merging all the above branches together I had to do some changes.
@packdat 's incremental save depends on the owner of the document, which caused problems because in some places of the code it was using parameterless constructors to create pdf objects losing the reference to owner document.
I removed all those constructors to ensure the owner is not being lost:
Havunen@7bd26eb
Havunen@f9f3b08
MS security patches:
Havunen@69ff104
Added GetSize method to ISigner interface
Havunen@17d0fa9
Havunen@39741e4
I removed the need to provide certificate, because in my use case the signature is made by external card reader (SCS device) and the application does not have access to the certificate.
I changed PDFSigner to support changing filter and subfilter types, because I had to use: ETSI.CAdES.detached
I Fixed An item with the same key has already been added Key. -exception
(Havunen@7b7d5d2)