qAsConst is deprecated, use std::as_const

[dfaure-kdab]

No description provided.

[AndreSomers]

Looks good to me, but this does mean we're requiring C++17. Is that intentional?

[dfaure-kdab]

I couldn't find a KDToolBox-wide CXX_STANDARD requirement, so I don't know what's the current status.
But well who doesn't have C++17 these days?

The bit I do need is UpdateableModel.h, for KDABViewer to build with recent Qt and without deprecation warnings.

[dantti]

I guess it needs to add KDTOOLBOX_CXX17 to disable building and likely requiring it when enabled for it to pass CI

[dfaure-kdab]

Qt 6 requires C++17 anyway, but I see the point about Qt5.
Can we make KDTOOLBOX_CXX17 default to ON though, and only disable it on old Qt5+old-compiler CI builds?

[dantti]

It can be on by default, CI compilers are all new enough, it's just that KDStlContainerAdaptor nor Qt5 requires C++-17.

[dfaure-kdab]

Hmm, actually instead of disabling entire subdirs for Qt5, I could just do "if qt6 use std::as_const else use qAsConst"

[dfaure-kdab]

Done. I reverted the change to qt/qml/PropertySelector/PropertySelector.cpp because that code isn't built anywhere so I can't test changes there => someone else's problem.

[dantti]

LGTM tho on the tests part I think you could've just made the vector const, no?

[dantti]

hmm there are changes to it

[dfaure-kdab]

ping? who approves KDToolBox merge requests?