Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lower default maxiters for fixpoint_sub #1349

Conversation

AayushSabharwal
Copy link
Contributor

10000 was a bit too high

@ChrisRackauckas ChrisRackauckas merged commit 8998fa8 into JuliaSymbolics:master Nov 6, 2024
10 of 12 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fixpoint-sub-maxiters branch November 6, 2024 08:04
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.98%. Comparing base (3e31a75) to head (5af597a).
Report is 56 commits behind head on master.

Files with missing lines Patch % Lines
src/variable.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1349      +/-   ##
=========================================
- Coverage    6.69%   3.98%   -2.71%     
=========================================
  Files          47      50       +3     
  Lines        4618    4771     +153     
=========================================
- Hits          309     190     -119     
- Misses       4309    4581     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants