Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for solve_interms_ofvar and bug fixes #1345

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

n0rbed
Copy link
Member

@n0rbed n0rbed commented Nov 4, 2024

Fixed multiplicity bugs by adding correct checking in solve_univar and added some tests for solve_interms_ofvar. One thing to note; solve_interms_ofvar doesnt work with parameters, so say the equations provided are one less than the variables present in the system, it wont get all the other variables in terms of one variable. E.g.:

julia> eq = (a*x+b)*s^2 - 2s^2 + 2*b*s - 3*s

julia> Symbolics.solve_interms_ofvar(eq, s)
┌ Warning: Infinite number of solutions
└ @ SymbolicsGroebnerExt ~/code/julia/Symbolics.jl/ext/SymbolicsGroebnerExt.jl:228
ERROR: AssertionError: Not a polynomial

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.55%. Comparing base (3e31a75) to head (62d8d0e).
Report is 29 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1345       +/-   ##
===========================================
+ Coverage    6.69%   78.55%   +71.86%     
===========================================
  Files          47       49        +2     
  Lines        4618     4813      +195     
===========================================
+ Hits          309     3781     +3472     
+ Misses       4309     1032     -3277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit d16bc03 into JuliaSymbolics:master Nov 5, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants