Skip to content

Commit

Permalink
Merge pull request #567 from ArnoStrouwen/qa
Browse files Browse the repository at this point in the history
Typos CI + remove old docs
  • Loading branch information
ChrisRackauckas authored Dec 19, 2023
2 parents 7916c04 + 1cb6481 commit d68e092
Show file tree
Hide file tree
Showing 96 changed files with 30 additions and 1,715 deletions.
10 changes: 10 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/" # Location of package manifests
schedule:
interval: "weekly"
ignore:
- dependency-name: "crate-ci/typos"
update-types: ["version-update:semver-patch"]
13 changes: 13 additions & 0 deletions .github/workflows/SpellCheck.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Spell Check

on: [pull_request]

jobs:
typos-check:
name: Spell Check with Typos
runs-on: ubuntu-latest
steps:
- name: Checkout Actions Repository
uses: actions/checkout@v3
- name: Check spelling
uses: crate-ci/[email protected]
3 changes: 3 additions & 0 deletions .typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[default.extend-words]
nd = "nd"
siz = "siz"
4 changes: 2 additions & 2 deletions docs/src/manual/representation.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ Note that in this case `recurse=true` was necessary as otherwise the polynomiali

### Simplifying fractions

`simplify_fractions(expr)` recurses through `expr` finding `Div`s and simplifying them using polynomial divison.
`simplify_fractions(expr)` recurses through `expr` finding `Div`s and simplifying them using polynomial division.

First the factors of the numerators and the denominators are converted into PolyForm objects, then numerators and denominators are divided by their respective pairwise GCDs. The conversion of the numerator and denominator into PolyForm is set up so that `simplify_fractions` does not result in increase in the expression size due to polynomial expansion. Specifically, the factors are individually converted into PolyForm objects, and any powers of polynomial is not expanded, but the divison process repeatedly divides them as many times as the power.
First the factors of the numerators and the denominators are converted into PolyForm objects, then numerators and denominators are divided by their respective pairwise GCDs. The conversion of the numerator and denominator into PolyForm is set up so that `simplify_fractions` does not result in increase in the expression size due to polynomial expansion. Specifically, the factors are individually converted into PolyForm objects, and any powers of polynomial is not expanded, but the division process repeatedly divides them as many times as the power.


```julia
Expand Down
2 changes: 1 addition & 1 deletion docs/src/manual/rewrite.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ rewriters.
- `RestartedChain(itr)` like `Chain(itr)` but restarts from the first rewriter once on the
first successful application of one of the chained rewriters.
- `IfElse(cond, rw1, rw2)` runs the `cond` function on the input, applies `rw1` if cond
returns true, `rw2` if it retuns false
returns true, `rw2` if it returns false
- `If(cond, rw)` is the same as `IfElse(cond, rw, Empty())`
- `Prewalk(rw; threaded=false, thread_cutoff=100)` returns a rewriter which does a pre-order
(*from top to bottom and from left to right*) traversal of a given expression and applies
Expand Down
1 change: 0 additions & 1 deletion page/.gitignore

This file was deleted.

3 changes: 0 additions & 3 deletions page/Project.toml

This file was deleted.

86 changes: 0 additions & 86 deletions page/_css/custom.css

This file was deleted.

Loading

0 comments on commit d68e092

Please sign in to comment.