Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Julia compat to 1.10 and update CI setup #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

devmotion
Copy link
Member

In #212, it was proposed to update the Julia compat to 1.10. I opened a separate PR for this move since there are quite many VERSION checks that we could (and should) get rid of in this update but these changes are really unrelated to #212 otherwise.

I used the opportunity to update the CI setup, and in particular add tests with min, lts and pre.

@timholy
Copy link
Contributor

timholy commented Dec 11, 2024

I'll rebase on this PR once it's merged.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.12%. Comparing base (b85c8ac) to head (024ece5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   91.61%   92.12%   +0.50%     
==========================================
  Files           9        9              
  Lines         680      660      -20     
==========================================
- Hits          623      608      -15     
+ Misses         57       52       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

os:
- ubuntu-latest
- ubuntu-latest # Apple Silicon
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to have this comment on this line or the following one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, of course it should be moved to the following line.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@timholy
Copy link
Contributor

timholy commented Dec 12, 2024

I wonder if it makes sense to bump the patch version here too, get a release out, and then bump again with #212?

@devmotion
Copy link
Member Author

I thought it would not be necessary to make a separate release with this PR since the PR does not (or at least should not) change the package itself in any way (apart from dropping support for Julia < 1.10).

@timholy
Copy link
Contributor

timholy commented Dec 12, 2024

Agreed. There's a couple of minor changes that haven't been released, though: v0.11.31...master

Probably doesn't matter, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants