-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Julia compat to 1.10 and update CI setup #213
base: master
Are you sure you want to change the base?
Conversation
I'll rebase on this PR once it's merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 91.61% 92.12% +0.50%
==========================================
Files 9 9
Lines 680 660 -20
==========================================
- Hits 623 608 -15
+ Misses 57 52 -5 ☔ View full report in Codecov by Sentry. |
.github/workflows/ci.yml
Outdated
os: | ||
- ubuntu-latest | ||
- ubuntu-latest # Apple Silicon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to have this comment on this line or the following one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, of course it should be moved to the following line.
I wonder if it makes sense to bump the patch version here too, get a release out, and then bump again with #212? |
I thought it would not be necessary to make a separate release with this PR since the PR does not (or at least should not) change the package itself in any way (apart from dropping support for Julia < 1.10). |
Agreed. There's a couple of minor changes that haven't been released, though: v0.11.31...master Probably doesn't matter, though. |
In #212, it was proposed to update the Julia compat to 1.10. I opened a separate PR for this move since there are quite many
VERSION
checks that we could (and should) get rid of in this update but these changes are really unrelated to #212 otherwise.I used the opportunity to update the CI setup, and in particular add tests with
min
,lts
andpre
.