Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed Matrix constructor and more stable tests #199

Merged
merged 20 commits into from
Dec 8, 2023

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Dec 8, 2023

I've removed the single-index getindex methods, as the AbstractArray fallback methods should suffice.

I've also ensured that the matrices are explicitly hermitian in the tests, which makes it less likely for cholesky to fail due to numerical precision issues. Further, I've added a random seed, which makes the tests easier to reproduce.

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd28425) 91.48% compared to head (c067537) 91.56%.

❗ Current head c067537 differs from pull request most recent head 5710a1b. Consider uploading reports for the commit 5710a1b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   91.48%   91.56%   +0.08%     
==========================================
  Files           9        9              
  Lines         681      676       -5     
==========================================
- Hits          623      619       -4     
+ Misses         58       57       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated Show resolved Hide resolved
src/pdiagmat.jl Show resolved Hide resolved
src/pdmat.jl Show resolved Hide resolved
src/pdsparsemat.jl Outdated Show resolved Hide resolved
test/pdmtypes.jl Outdated Show resolved Hide resolved
test/pdmtypes.jl Outdated Show resolved Hide resolved
test/pdmtypes.jl Outdated Show resolved Hide resolved
test/pdmtypes.jl Outdated Show resolved Hide resolved
test/pdmtypes.jl Outdated Show resolved Hide resolved
test/specialarrays.jl Outdated Show resolved Hide resolved
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, thank you!

@devmotion devmotion merged commit fd220fa into JuliaStats:master Dec 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants