Support StaticArrays in X(t)_(inv)A_X(t) with ScalMat #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ScalMat
does not supportX_A_Xt
etc. with static arrays. For instance, running the tests in this PR on the master branch yieldsThe PR fixes this issue by changing the implementation to a non-mutating alternative, as done already e.g. for
PDiagMat
.The disadvantage (also with the existing code for other psd matrix types) is that this leads to additional allocations when working with e.g.
Array
. I wonder if generally the non-mutating implementation should be the default (since it works with any matrix type) and additionally possibly internally mutating code forArray
should be added (since it avoids allocations and this particular matrix type is so common).