Merge branch 'master' into dw/unify_pdmat_pdsparsemat

.github/workflows/IntegrationTest.yml

@@ -0,0 +1,58 @@
+name: IntegrationTest
+
+on:
+  pull_request:
+    branches:
+      - master
+  push:
+    branches:
+      - master
+    tags: '*'
+
+concurrency:
+  # Skip intermediate builds: always.
+  # Cancel intermediate builds: only if it is a pull request build.
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: ${{ startsWith(github.ref, 'refs/pull/') }}
+
+jobs:
+  test:
+    name: ${{ matrix.package.repo }}/${{ matrix.package.group }}
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        julia-version: [1]
+        os: [ubuntu-latest]
+        package:
+          - {user: JuliaStats, repo: Distributions.jl}
+
+    steps:
+      - uses: actions/checkout@v4
+      - uses: julia-actions/setup-julia@v1
+        with:
+          version: ${{ matrix.julia-version }}
+          arch: x64
+      - uses: julia-actions/julia-buildpkg@v1
+      - name: Clone Downstream
+        uses: actions/checkout@v4
+        with:
+          repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
+          path: downstream
+      - name: Load this and run the downstream tests
+        shell: julia --color=yes --project=downstream {0}
+        run: |
+          using Pkg
+          try
+            # force it to use this PR's version of the package
+            Pkg.develop(PackageSpec(path="."))  # resolver may fail with main deps
+            Pkg.update()
+            Pkg.test()  # resolver may fail with test time deps
+          catch err
+            err isa Pkg.Resolve.ResolverError || rethrow()
+            # If we can't resolve that means this is incompatible by SemVer and this is fine
+            # It means we marked this as a breaking change, so we don't need to worry about
+            # Mistakenly introducing a breaking change, as we have intentionally made one
+            @info "Not compatible with this release. No problem." exception=err
+            exit(0)  # Exit immediately, as a success
+          end

test/specialarrays.jl

@@ -28,6 +28,8 @@ using StaticArrays
         Y = @SMatrix rand(4, 10)
 
         for A in (PDS, D, E, C)
+            @test Matrix(A) isa Matrix
+
             if !(A isa Cholesky)
                 # `*(::Cholesky, ::SArray)` is not defined
                 @test A * x isa SVector{4, Float64}

test/testutils.jl

@@ -114,6 +114,11 @@ function pdtest_basics(C, Cmat::Matrix, d::Int, verbose::Int)
     if C isa AbstractPDMat
         @test M === C
     end
+
+    _pdt(verbose, "Matrix")
+    M = Matrix(C)
+    @test M isa Matrix
+    @test M == Cmat
 end