Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add julia compat bounds to Ipopt_jll #80632

Closed

Conversation

Vaibhavdixit02
Copy link
Contributor

@odow do you think this is reasonable?

@odow
Copy link
Contributor

odow commented Mar 30, 2023

Not really. Everything works on v1.8, except the Windows executable. And I don't know if we have shown that it works on Julia 1.9?

cc @amontoison

@amontoison
Copy link
Contributor

@Vaibhavdixit02 Why do you want to update the julia compat of Ipopt_jll?

@Vaibhavdixit02
Copy link
Contributor Author

Everything works on v1.8, except the Windows executable.

Not the releases, right? The issue was not just in Windows, it doesn't work on mac and linux also https://github.com/jump-dev/AmplNLWriter.jl/actions/runs/4466436440/jobs/7844624260. Your PR jump-dev/AmplNLWriter.jl#163 iiuc fixes it for everything other than Windows though?

Why do you want to update the julia compat of Ipopt_jll?

Based on the comments jump-dev/AmplNLWriter.jl#163 (comment) and jump-dev/AmplNLWriter.jl#163 (comment) my understanding is that post 1.9 we will able to ship Ipopt_jll with only LBT and avoid the issue (jump-dev/AmplNLWriter.jl#162)

@odow
Copy link
Contributor

odow commented Mar 31, 2023

Yip, the other platforms fail because we haven't merged jump-dev/AmplNLWriter.jl#163.

my understanding is that post 1.9 we will able to ship Ipopt_jll with only LBT and avoid the issue

I don't know if we've confirmed that that will fix the issue?

@Vaibhavdixit02
Copy link
Contributor Author

I don't know if we've confirmed that that will fix the issue?

That's true, but we also know that it doesn't work on anything <1.9 😅

@amontoison
Copy link
Contributor

amontoison commented Mar 31, 2023

@Vaibhavdixit02
I'm sorry but I still don't understand the issue.
Ipopt_jll works for all platforms if we use it with Ipopt.jl.
If we use Ipopt_jll with AmplNLWriter.jl we need some modifications to support the artifacts precompiled with LBT but the release 1.0.2 fixed all problems by using the last Ipopt_jll precompiled with OpenBLAS32_jll.

@Vaibhavdixit02
Copy link
Contributor Author

I haven't really explained the issue I realise that now, sorry. The thing is https://github.com/SciML/ModelingToolkit.jl/actions/runs/4559568146/jobs/8071636678#step:6:41 because Ipopt_jll > 400 is available, the resolver doesn't pick AmplNLWriter 1.0.2 (or OptimizationMOI 0.1.11)

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Apr 30, 2023
@Vaibhavdixit02 Vaibhavdixit02 deleted the patch-2 branch April 30, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants