-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add julia compat bounds to Ipopt_jll #80632
Conversation
Not really. Everything works on v1.8, except the Windows executable. And I don't know if we have shown that it works on Julia 1.9? cc @amontoison |
@Vaibhavdixit02 Why do you want to update the julia compat of Ipopt_jll? |
Not the releases, right? The issue was not just in Windows, it doesn't work on mac and linux also https://github.com/jump-dev/AmplNLWriter.jl/actions/runs/4466436440/jobs/7844624260. Your PR jump-dev/AmplNLWriter.jl#163 iiuc fixes it for everything other than Windows though?
Based on the comments jump-dev/AmplNLWriter.jl#163 (comment) and jump-dev/AmplNLWriter.jl#163 (comment) my understanding is that post 1.9 we will able to ship Ipopt_jll with only LBT and avoid the issue (jump-dev/AmplNLWriter.jl#162) |
Yip, the other platforms fail because we haven't merged jump-dev/AmplNLWriter.jl#163.
I don't know if we've confirmed that that will fix the issue? |
That's true, but we also know that it doesn't work on anything <1.9 😅 |
@Vaibhavdixit02 |
I haven't really explained the issue I realise that now, sorry. The thing is https://github.com/SciML/ModelingToolkit.jl/actions/runs/4559568146/jobs/8071636678#step:6:41 because Ipopt_jll > 400 is available, the resolver doesn't pick AmplNLWriter 1.0.2 (or OptimizationMOI 0.1.11) |
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
@odow do you think this is reasonable?